Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/Service/Logger.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,27 @@ export default class LoggerService extends DependencyAwareClass {
this.logger.log('info', this.processMessage(message));
}

/**
* Logs an error, using `LoggerService.error`
* or `LoggerService.info` based on
* `process.env.LOGGER_SOFT_WARNING`.
*
* Please note that `LoggerService.error` and `LoggerService.info`
* have different signatures. The function uses the shared argument
* instead of introducing ambiguity.
*
* @param error
*/
warning(error) {
const softWarningValues = ['true', '1'];

if (softWarningValues.includes(process.env.LOGGER_SOFT_WARNING)) {
return this.info(error);
}

return this.error(error);
}

/**
* Add a label
*
Expand Down
34 changes: 34 additions & 0 deletions tests/unit/Service/Logger.service.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -133,4 +133,38 @@ describe('Service/LoggerService', () => {
});
});
});

describe('warning', () => {
let LOGGER_SOFT_WARNING;

beforeAll(() => {
LOGGER_SOFT_WARNING = process.env.LOGGER_SOFT_WARNING;
});

afterAll(() => {
process.env.LOGGER_SOFT_WARNING = LOGGER_SOFT_WARNING;
});

[
['', 'error'],
['some-value', 'error'],
[false, 'error'],
['false', 'error'],
['0', 'error'],
['1', 'info'],
[true, 'info'],
['true', 'info'],
].forEach(([loggerSoftWarning, func]) => {
it(`uses 'this.logger.${func}' in ${loggerSoftWarning}`, () => {
process.env.LOGGER_SOFT_WARNING = loggerSoftWarning;
const logger = getLogger();

jest.spyOn(logger, func).mockImplementation(() => {});

logger.warning({});

expect(logger[func]).toHaveBeenCalledTimes(1);
});
});
});
});