Skip to content

fix: Support additional HTTP methods #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dipasqualew merged 5 commits into from
Jan 22, 2021
Merged

fix: Support additional HTTP methods #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5030062
fix: Support additional HTTP methods
dipasqualew Jan 22, 2021
29e884f
ordered method by type and alphabetically
dipasqualew Jan 22, 2021
f17b3ce
don't resolve true, keep compatibility
dipasqualew Jan 22, 2021
5eb3438
rename tests
dipasqualew Jan 22, 2021
6f8bb16
improved snapshots
dipasqualew Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/Service/Request.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,28 @@ import DependencyAwareClass from '../DependencyInjection/DependencyAware.class';
import ResponseModel from '../Model/Response.model';

export const REQUEST_TYPES = {
DELETE: 'DELETE',
GET: 'GET',
HEAD: 'HEAD',
OPTIONS: 'OPTIONS',
PATCH: 'PATCH',
POST: 'POST',
PUT: 'PUT',
};

export const HTTP_METHODS_WITHOUT_PAYLOADS = [
REQUEST_TYPES.DELETE,
REQUEST_TYPES.GET,
REQUEST_TYPES.HEAD,
REQUEST_TYPES.OPTIONS,
];

export const HTTP_METHODS_WITH_PAYLOADS = [
REQUEST_TYPES.PATCH,
REQUEST_TYPES.POST,
REQUEST_TYPES.PUT,
];

// Define action specific error types
export const ERROR_TYPES = {
VALIDATION_ERROR: new ResponseModel({}, 400, 'required fields are missing'),
Expand Down Expand Up @@ -130,11 +148,11 @@ export default class RequestService extends DependencyAwareClass {
getAll(requestType = null) {
const event = this.getContainer().getEvent();

if (event.httpMethod === 'GET' || requestType === REQUEST_TYPES.GET) {
if (HTTP_METHODS_WITHOUT_PAYLOADS.includes(event.httpMethod) || HTTP_METHODS_WITHOUT_PAYLOADS.includes(requestType)) {
return typeof event.queryStringParameters !== 'undefined' ? event.queryStringParameters : {};
}

if (event.httpMethod === 'POST' || requestType === REQUEST_TYPES.POST) {
if (HTTP_METHODS_WITH_PAYLOADS.includes(event.httpMethod) || HTTP_METHODS_WITH_PAYLOADS.includes(requestType)) {
const contentType = this.getHeader('Content-Type');
let queryParameters = {};

Expand All @@ -152,11 +170,7 @@ export default class RequestService extends DependencyAwareClass {

if (contentType.includes('text/xml')) {
XML2JS.parseString(event.body, (error, result) => {
if (error) {
queryParameters = {};
} else {
queryParameters = result;
}
queryParameters = error ? {} : result;
});
}

Expand Down
Loading