Open
Conversation
Builds qtbase, qtcharts, qtserialbus 5.15.2 as shared libraries. Includes moc/rcc tools, platform plugins, and minimal headers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Qt 5.15.2 missing #include <limits> causes build failure on modern compilers (manylinux_2_28 arm64 has GCC 12+). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Qt 5.15.2 qmake configure uses 'printer' as the feature name, not 'printsupport' (which is the module name). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add #include <limits> to qglobal.h (root header) so it propagates to all Qt source files. Fixes qbytearraymatcher.h and others. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Qt 5.15.2 uses qmake-based configure, not CMake. The '--' separator causes 'Unknown command line option' on macOS. -fPIC is already default for shared builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previous sed anchor pattern didn't exist in qglobal.h, so the #include <limits> was never actually inserted. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Patching qglobal.h at line 1 broke the bootstrap qmake build which doesn't have full C++ stdlib headers in its include path. Instead, pass QMAKE_CXXFLAGS+="-include limits" via configure, which only affects the main qmake-driven build (not bootstrap). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Qt 5.15.2 has missing <limits> includes that cause build failures with modern compilers. 5.15.18 (community LTS) has these fixes upstream, eliminating the need for source patches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tarball is named *-opensource-src-* but extracts to *-src-*. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan