Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in runtime in carstate.py #128

Closed
githubuse opened this issue Aug 17, 2017 · 1 comment
Closed

error in runtime in carstate.py #128

githubuse opened this issue Aug 17, 2017 · 1 comment

Comments

@githubuse
Copy link

githubuse commented Aug 17, 2017

hi all, it's easy to be reproduce, version 0.3.6
openpilot will show exception in "self.brake_switch_ts = cp.ts[0x17C]['BRAKE_SWITCH']" in carstate.py file, because "cp.ts[0x17C]" is just a timestamp instead of a dictionay, we could see where it's filled value in function "update_can" in car_parser.py.
so i think here it should be "self.brake_switch_ts = cp.ts[0x17C]",please help confirm,thanks

@espes
Copy link

espes commented Aug 17, 2017

can_parser.py isn't used by default. selfdrive/can/parser.py exposes ts as a dictionary

@espes espes closed this as completed Aug 17, 2017
rbiasini pushed a commit that referenced this issue Aug 21, 2018
b058c14 add build step for legacy board to CI
866dd85 Fix README (#133)
c2a0853 Hyundai safety: 593 also needs ot be modified
594863c Hyundai: added initial safety files which just fwd bus 0 to 2 and viceversa, except for lkas msgs
905a935 fixed pedal and legacy board builds: no float support
0a480ec moved interpolate function to safety header
d7bd473 Merge pull request #131 from appleguru/master
c0b1ef2 Example to get wifi password from panda over USB using python library
01c0383 Merge pull request #128 from appleguru/gmlan_gpio
f9a46e3 Match safety order from master
aafbe05 GMLAN GPIO Rebase
37df290 rename to gmlan_alt

git-subtree-dir: panda
git-subtree-split: b058c14
rbiasini pushed a commit that referenced this issue Jan 25, 2019
b632acf new GM powertrain signals (#136)
ef8c223 Toyota: clarified lane line VALs
6567d24 Toyota: added more info to long control message
6730303 Run generator again and added Toyota Sienna
85de1ff Chrysler message to play an audible beep & ACC cancel (#133)
6824002 Chrysler: fixed torque motor understanding
7ea8318 Add DSU Speed (#134)
8094782 Chrysler: minor message renaming
9578326 Chrysler: beter names and LKAS_HUD message understood
59eaae9 Chrysler: added lkas icon color signal
63be265 added torque driver and torque motor
225beb2 Chrysler: no more big endian
41ec067 Chrysler: less big endian in dbc
8cc8da3 Chrysler: no big endian
166b32b Chrysler: naming consistency
1c1dd5a Chrysler: seems more correct for torque
1d64206 Hyundai Cleanup (#130)
bcde8fd GM Object Front Cam Signals (#128)
8ac852b Add Chrysler ACC cancel button (#127)

git-subtree-dir: opendbc
git-subtree-split: b632acf
avolmensky pushed a commit to avolmensky/openpilot that referenced this issue Jun 10, 2019
* new f cam signals

* added objecttype

* cut in out table
avolmensky pushed a commit to avolmensky/openpilot that referenced this issue Jun 30, 2019
Add an alternate function to use GMLAN output on panda as a GPIO
sshane referenced this issue in sshane/openpilot Nov 26, 2019
weimou pushed a commit to SFtoLA/openpilot that referenced this issue May 6, 2021
* add check for average frequency

* fix mypy

* more type errors

* make less strict

* only check polled services

* add flag to disable avg check
nworb-cire pushed a commit to opgm/openpilot that referenced this issue Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants