Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbc File overlapping #541

Closed
ashtonaureleo opened this issue Feb 26, 2019 · 5 comments
Closed

dbc File overlapping #541

ashtonaureleo opened this issue Feb 26, 2019 · 5 comments
Assignees

Comments

@ashtonaureleo
Copy link

Hi,
We are trying to read CAN messages of Toyota Prius 2017 and translate into human readable using cantools package which uses the toyota_prius_2017_pt_generated.dbc file in opendbc folder.

Cantools.decode throws an error saying IPAS steering commands are overlapping.
Can the dbc file be edited to remove the error by rearranging the bits?
Will the ECU be able to read messages provided by cantools.encode based on the rearranged signals?

Could you suggest any other way to read CAN messages besides using cantools and dbc file?
Below is the Overlapping content of the Steering IPAS from dbc:

BO_ 359 STEERING_IPAS_COMMA: 8 IPAS
SG_ STATE : 7|4@0+ (1,0) [0|15] "" XXX
SG_ ANGLE : 3|12@0- (1.5,0) [-510|510] "deg" XXX
SG_ SET_ME_X10 : 23|8@0+ (1,0) [0|255] "" XXX
SG_ SET_ME_X00 : 31|8@0+ (1,0) [0|255] "" XXX
SG_ DIRECTION_CMD : 38|2@0+ (1,0) [0|3] "" XXX
SG_ SET_ME_X40 : 47|8@0+ (1,0) [0|255] "" XXX
SG_ SET_ME_X00 : 55|8@0+ (1,0) [0|255] "" XXX
SG_ CHECKSUM : 63|8@0+ (1,0) [0|255] "" XXX

@legonigel
Copy link

Did you find any issue and fix with the DBC file? If so please open a PR in commaai/opendbc.

@rbiasini
Copy link
Contributor

rbiasini commented Jun 2, 2019

I don't think those signals are overlapping. Are they? Remember, this is little endian.

@ashtonaureleo
Copy link
Author

The issue was due to SET_ME_X00 in steering IPAS id: 614message. There are two signals with the same name(SET_ME_X00). I have just renamed one of these signals as SET_ME_X00_edit.
toyota_prius_2017_pt_generated_for_cantools.zip

@rbiasini
Copy link
Contributor

rbiasini commented Jun 3, 2019

ah yes, that's right. Let me fix it.

@rbiasini
Copy link
Contributor

rbiasini commented Jun 3, 2019

fixed in commaai/opendbc@34bd4c4

@rbiasini rbiasini closed this as completed Jun 3, 2019
pd0wm pushed a commit that referenced this issue May 28, 2020
bdec139 Fix length of 0x20b in NISSAN_TX_MSGS, wasn't cancelling ACC (#544)
b48c74c Adding UNO to automated tests (#538)
a5802cd Hyundai: remove unused message from RX checks
9ebde25 Reset state on safety mode init (#542)
d4f3f15 Refactor addr check (#541)
5210e51 remove unused files
0657064 Hyundai checksum (#540)
07e668e Fast CI (#539)
5307bf7 Fix multi message iso tp requests
0610ed1 Hyundai wheel speed counter is actually 4 bits spread over two signals
0d581aa dockerfile optimization
eaefa2f fix docker file path
243a65f pull base image
0dd9470 only push to dockerhub from master
55b79b4 GitHub Actions (#535)
b2c720b Dos (#533)
01bf740 remove 0x1BE checksum test
0bd06c9 remove 0x1BE check (breaks some vehicles)
c31b899 honda bosch longitudinal safety
66250c4 Disable docker layer caching (#534)
6b19fa4 include nissan safety in release build
db31886 gate mazda safety behind debug flag
e4558c0 Safety: message length check on RX and TX (#529)

git-subtree-dir: panda
git-subtree-split: bdec139
pd0wm pushed a commit that referenced this issue May 28, 2020
bdec139 Fix length of 0x20b in NISSAN_TX_MSGS, wasn't cancelling ACC (#544)
b48c74c Adding UNO to automated tests (#538)
a5802cd Hyundai: remove unused message from RX checks
9ebde25 Reset state on safety mode init (#542)
d4f3f15 Refactor addr check (#541)
5210e51 remove unused files
0657064 Hyundai checksum (#540)
07e668e Fast CI (#539)
5307bf7 Fix multi message iso tp requests
0610ed1 Hyundai wheel speed counter is actually 4 bits spread over two signals
0d581aa dockerfile optimization
eaefa2f fix docker file path
243a65f pull base image
0dd9470 only push to dockerhub from master
55b79b4 GitHub Actions (#535)
b2c720b Dos (#533)
01bf740 remove 0x1BE checksum test
0bd06c9 remove 0x1BE check (breaks some vehicles)
c31b899 honda bosch longitudinal safety
66250c4 Disable docker layer caching (#534)
6b19fa4 include nissan safety in release build
db31886 gate mazda safety behind debug flag
e4558c0 Safety: message length check on RX and TX (#529)

git-subtree-dir: panda
git-subtree-split: bdec139
pd0wm pushed a commit that referenced this issue May 28, 2020
bdec139 Fix length of 0x20b in NISSAN_TX_MSGS, wasn't cancelling ACC (#544)
b48c74c Adding UNO to automated tests (#538)
a5802cd Hyundai: remove unused message from RX checks
9ebde25 Reset state on safety mode init (#542)
d4f3f15 Refactor addr check (#541)
5210e51 remove unused files
0657064 Hyundai checksum (#540)
07e668e Fast CI (#539)
5307bf7 Fix multi message iso tp requests
0610ed1 Hyundai wheel speed counter is actually 4 bits spread over two signals
0d581aa dockerfile optimization
eaefa2f fix docker file path
243a65f pull base image
0dd9470 only push to dockerhub from master
55b79b4 GitHub Actions (#535)
b2c720b Dos (#533)
01bf740 remove 0x1BE checksum test
0bd06c9 remove 0x1BE check (breaks some vehicles)
c31b899 honda bosch longitudinal safety
66250c4 Disable docker layer caching (#534)
6b19fa4 include nissan safety in release build
db31886 gate mazda safety behind debug flag
e4558c0 Safety: message length check on RX and TX (#529)

git-subtree-dir: panda
git-subtree-split: bdec139
pd0wm pushed a commit that referenced this issue May 29, 2020
b826734 Add pre commit checks + CI (#545)
339976c document tx message addresses better (#543)
a618e64 fix typing errors
9bece64 use mazda init
08db086 mazda cleanup
89658d0 Mazda: safety tests add missing safety checks (#525)
bdec139 Fix length of 0x20b in NISSAN_TX_MSGS, wasn't cancelling ACC (#544)
b48c74c Adding UNO to automated tests (#538)
a5802cd Hyundai: remove unused message from RX checks
9ebde25 Reset state on safety mode init (#542)
d4f3f15 Refactor addr check (#541)
5210e51 remove unused files
0657064 Hyundai checksum (#540)
07e668e Fast CI (#539)
5307bf7 Fix multi message iso tp requests
0610ed1 Hyundai wheel speed counter is actually 4 bits spread over two signals
0d581aa dockerfile optimization
eaefa2f fix docker file path
243a65f pull base image
0dd9470 only push to dockerhub from master
55b79b4 GitHub Actions (#535)
b2c720b Dos (#533)
01bf740 remove 0x1BE checksum test
0bd06c9 remove 0x1BE check (breaks some vehicles)
c31b899 honda bosch longitudinal safety
66250c4 Disable docker layer caching (#534)
6b19fa4 include nissan safety in release build
db31886 gate mazda safety behind debug flag
e4558c0 Safety: message length check on RX and TX (#529)

git-subtree-dir: panda
git-subtree-split: b826734
pd0wm pushed a commit that referenced this issue May 31, 2020
49ffbe9 disable non-universal checks in hyundai safety
3a85f4c use whole route when running safety replay from CLI
098f47a Fix leaf brake rx check (#547)
b826734 Add pre commit checks + CI (#545)
339976c document tx message addresses better (#543)
a618e64 fix typing errors
9bece64 use mazda init
08db086 mazda cleanup
89658d0 Mazda: safety tests add missing safety checks (#525)
bdec139 Fix length of 0x20b in NISSAN_TX_MSGS, wasn't cancelling ACC (#544)
b48c74c Adding UNO to automated tests (#538)
a5802cd Hyundai: remove unused message from RX checks
9ebde25 Reset state on safety mode init (#542)
d4f3f15 Refactor addr check (#541)
5210e51 remove unused files
0657064 Hyundai checksum (#540)
07e668e Fast CI (#539)
5307bf7 Fix multi message iso tp requests
0610ed1 Hyundai wheel speed counter is actually 4 bits spread over two signals
0d581aa dockerfile optimization
eaefa2f fix docker file path
243a65f pull base image
0dd9470 only push to dockerhub from master
55b79b4 GitHub Actions (#535)
b2c720b Dos (#533)
01bf740 remove 0x1BE checksum test
0bd06c9 remove 0x1BE check (breaks some vehicles)
c31b899 honda bosch longitudinal safety
66250c4 Disable docker layer caching (#534)
6b19fa4 include nissan safety in release build
db31886 gate mazda safety behind debug flag
e4558c0 Safety: message length check on RX and TX (#529)

git-subtree-dir: panda
git-subtree-split: 49ffbe9
pd0wm pushed a commit that referenced this issue May 31, 2020
9102c16 two spaces before inline comment
49ffbe9 disable non-universal checks in hyundai safety
3a85f4c use whole route when running safety replay from CLI
098f47a Fix leaf brake rx check (#547)
b826734 Add pre commit checks + CI (#545)
339976c document tx message addresses better (#543)
a618e64 fix typing errors
9bece64 use mazda init
08db086 mazda cleanup
89658d0 Mazda: safety tests add missing safety checks (#525)
bdec139 Fix length of 0x20b in NISSAN_TX_MSGS, wasn't cancelling ACC (#544)
b48c74c Adding UNO to automated tests (#538)
a5802cd Hyundai: remove unused message from RX checks
9ebde25 Reset state on safety mode init (#542)
d4f3f15 Refactor addr check (#541)
5210e51 remove unused files
0657064 Hyundai checksum (#540)
07e668e Fast CI (#539)
5307bf7 Fix multi message iso tp requests
0610ed1 Hyundai wheel speed counter is actually 4 bits spread over two signals
0d581aa dockerfile optimization
eaefa2f fix docker file path
243a65f pull base image
0dd9470 only push to dockerhub from master
55b79b4 GitHub Actions (#535)
b2c720b Dos (#533)
01bf740 remove 0x1BE checksum test
0bd06c9 remove 0x1BE check (breaks some vehicles)
c31b899 honda bosch longitudinal safety
66250c4 Disable docker layer caching (#534)
6b19fa4 include nissan safety in release build
db31886 gate mazda safety behind debug flag
e4558c0 Safety: message length check on RX and TX (#529)

git-subtree-dir: panda
git-subtree-split: 9102c16
pd0wm pushed a commit that referenced this issue Jun 1, 2020
d7f7b14 Enable almost all Flake8 checks (#548)
3d5a717 fix whitespace after opening bracket
f70ef29 whitespace fix
eba113c backslash is redundant between brackets
8039638 fix linter complaint about unexpected spaces around keyword / parameter equals
275e76c fix linter complaint about too many blank lines
9102c16 two spaces before inline comment
49ffbe9 disable non-universal checks in hyundai safety
3a85f4c use whole route when running safety replay from CLI
098f47a Fix leaf brake rx check (#547)
b826734 Add pre commit checks + CI (#545)
339976c document tx message addresses better (#543)
a618e64 fix typing errors
9bece64 use mazda init
08db086 mazda cleanup
89658d0 Mazda: safety tests add missing safety checks (#525)
bdec139 Fix length of 0x20b in NISSAN_TX_MSGS, wasn't cancelling ACC (#544)
b48c74c Adding UNO to automated tests (#538)
a5802cd Hyundai: remove unused message from RX checks
9ebde25 Reset state on safety mode init (#542)
d4f3f15 Refactor addr check (#541)
5210e51 remove unused files
0657064 Hyundai checksum (#540)
07e668e Fast CI (#539)
5307bf7 Fix multi message iso tp requests
0610ed1 Hyundai wheel speed counter is actually 4 bits spread over two signals
0d581aa dockerfile optimization
eaefa2f fix docker file path
243a65f pull base image
0dd9470 only push to dockerhub from master
55b79b4 GitHub Actions (#535)
b2c720b Dos (#533)
01bf740 remove 0x1BE checksum test
0bd06c9 remove 0x1BE check (breaks some vehicles)
c31b899 honda bosch longitudinal safety
66250c4 Disable docker layer caching (#534)
6b19fa4 include nissan safety in release build
db31886 gate mazda safety behind debug flag
e4558c0 Safety: message length check on RX and TX (#529)

git-subtree-dir: panda
git-subtree-split: d7f7b14
pd0wm pushed a commit that referenced this issue Jun 1, 2020
d7f7b14 Enable almost all Flake8 checks (#548)
3d5a717 fix whitespace after opening bracket
f70ef29 whitespace fix
eba113c backslash is redundant between brackets
8039638 fix linter complaint about unexpected spaces around keyword / parameter equals
275e76c fix linter complaint about too many blank lines
9102c16 two spaces before inline comment
49ffbe9 disable non-universal checks in hyundai safety
3a85f4c use whole route when running safety replay from CLI
098f47a Fix leaf brake rx check (#547)
b826734 Add pre commit checks + CI (#545)
339976c document tx message addresses better (#543)
a618e64 fix typing errors
9bece64 use mazda init
08db086 mazda cleanup
89658d0 Mazda: safety tests add missing safety checks (#525)
bdec139 Fix length of 0x20b in NISSAN_TX_MSGS, wasn't cancelling ACC (#544)
b48c74c Adding UNO to automated tests (#538)
a5802cd Hyundai: remove unused message from RX checks
9ebde25 Reset state on safety mode init (#542)
d4f3f15 Refactor addr check (#541)
5210e51 remove unused files
0657064 Hyundai checksum (#540)
07e668e Fast CI (#539)
5307bf7 Fix multi message iso tp requests
0610ed1 Hyundai wheel speed counter is actually 4 bits spread over two signals
0d581aa dockerfile optimization
eaefa2f fix docker file path
243a65f pull base image
0dd9470 only push to dockerhub from master
55b79b4 GitHub Actions (#535)
b2c720b Dos (#533)
01bf740 remove 0x1BE checksum test
0bd06c9 remove 0x1BE check (breaks some vehicles)
c31b899 honda bosch longitudinal safety
66250c4 Disable docker layer caching (#534)
6b19fa4 include nissan safety in release build
db31886 gate mazda safety behind debug flag
e4558c0 Safety: message length check on RX and TX (#529)

git-subtree-dir: panda
git-subtree-split: d7f7b14
github-actions bot pushed a commit to LexusRXopenpilotUG/openpilot that referenced this issue Dec 29, 2021
* fix black path at high curvatures

* not const

* only do caluclation when enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants