2017 Honda Ridgeline #198
Merged
2017 Honda Ridgeline #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
energee
force-pushed
the
ridgeline
branch
3 times, most recently
from
39a496f
to
476dea8
Compare
|
Nice! @energee , let me know when it's ready to be reviewed. |
energee
commented
Feb 23, 2018
selfdrive/car/honda/hondacan.py
Outdated
| commands.append(make_can_msg(0x300, msg_0x300, idx, 1)) | ||
| elif car_fingerprint == CAR.PILOT: | ||
| msg_0x301 = "\x00\x00\x56\x02\x58\x00\x00" | ||
| commands.append(make_can_msg(0x300, msg_0x300, idx, 1)) |
There was a problem hiding this comment.
@rbiasini Are you ok with this change?
There was a problem hiding this comment.
Refactored so commands.append(make_can_msg(0x300, msg_0x300, idx, 1)) is written once
|
@rbiasini This is looking like its ready to be merged, can you send me the checklist again? |
|
@energee , the checklist in the Toyota port pretty much applies to the Honda as well. |
energee
force-pushed
the
ridgeline
branch
3 times, most recently
from
13b8b80
to
78e0606
Compare
energee
force-pushed
the
ridgeline
branch
7 times, most recently
from
d939615
to
e3e1365
Compare
|
I've a 2018 ridgeline rtl-e |
|
The RTL-E and Black Edition have Honda sense with ACC and LKAS. Its the same as your existing ridgeline guy (I saw his utube video...very thrilled to see this come together) |
|
@BlaineHa you should join the slack for more details http://slack.comma.ai |
Replaced trim level placeholder Adding 0x301 ridgeline message (I restructured this slightly since we don't need to repeat `commands.append(make_can_msg(0x300, msg_0x300, idx, 1))` so many times Updated dbc name Use pedal_gas to detect gas pressed Remove unnecessary signal check Fix array notation
This reverts commit 349edf5b1a879cac704db3786d0626211497bcb7.
update variables for failing build
|
Nice job guys, merging. |
Gernby
added a commit
to Gernby/openpilot
that referenced
this pull request
Jul 26, 2019
* Updated GM Volt values * updated dashcam and poly-center * Updated Honda parameters
Chrispreilly
pushed a commit
to Chrispreilly/openpilot
that referenced
this pull request
Nov 21, 2019
Maelstrom96
pushed a commit
to Maelstrom96/openpilot
that referenced
this pull request
Dec 15, 2019
StrTq max LKA stock req
dragonpilot
referenced
this pull request
in dragonpilot-community/dragonpilot
Apr 7, 2020
* Adds Honda Ridgeline Replaced trim level placeholder Adding 0x301 ridgeline message (I restructured this slightly since we don't need to repeat `commands.append(make_can_msg(0x300, msg_0x300, idx, 1))` so many times Updated dbc name Use pedal_gas to detect gas pressed Remove unnecessary signal check Fix array notation * Tire stiffness factor bumped to 1.5x * Adds safety tests at line 133 * Revert "Adds safety tests at line 133" This reverts commit 349edf5b1a879cac704db3786d0626211497bcb7. * fix failing build due to syntax * update variables for failing build * Update interface.py * Update Tire Slip Factor
debugged-tech
pushed a commit
to debugged-tech/DebuggedPilot
that referenced
this pull request
Sep 14, 2020
* merge ZSS to SA (#197) * SnG hack * Eased up Internet requirement See... commaai#1096 * VBATT CHARGING & Turn off charge after 3 hrs * Prii ZSS w/ Prime-centric tuning, etc. * Minimized custom fork warning * Update interface.py * Update thermald.py * Update interface.py * Update interface.py * Update lane_planner.py * ZSS Prius INDI Tune Co-authored-by: ErichMoraga <33645296+ErichMoraga@users.noreply.github.com> Co-authored-by: ErichMoraga <mailto:ejmoraga@gmail.com|ejmoraga@gmail.com> Co-authored-by: d412k5t412 <36134180+d412k5t412@users.noreply.github.com> * revert chmod * revert chmod * revert comment for standstill_req * revert interface changes * revert all carstate changes * add code to detect ZSS * fix * add ZSS code * use needs_angle_offset * switch around for diff readability * diff readability * diff readability * test * this should work * move code * ugh, fix * this should work * use hex like the other fp checks * ZSS tuning * revert to test * better implementation of getting ZSS * better implementation of getting ZSS * revert * follow naming conventions * simplify hasZss tuning * one line * debug * rename * gather more data * remove debugging * just for safety * this is probably better * nah this is fine Co-authored-by: ErichMoraga <33645296+ErichMoraga@users.noreply.github.com> Co-authored-by: ErichMoraga <mailto:ejmoraga@gmail.com|ejmoraga@gmail.com> Co-authored-by: d412k5t412 <36134180+d412k5t412@users.noreply.github.com>
nworb-cire
pushed a commit
to opgm/openpilot
that referenced
this pull request
Aug 2, 2024
* Road Edge Detection: toggle state fix * one liner * Revert "one liner" This reverts commit 44a34a3505456181af47329fbe76119c7fa204fb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar to the Pilot, dbc PR here. Will need the person with Ridgeline to verify the TX message for the radar once they get their EON/giraffe set up. I am assuming it matches the Pilot for now.