Conversation
adeebshihadeh
approved these changes
Apr 10, 2026
Contributor
|
This new check matches traffic on my model S causing ignition to stay high. not sure if we can pick another address or be more specific in this hook? |
Contributor
Author
|
@robbederks thanks for the catch, I should be more specific with length of message: #2388 can you please check if this works? If not I will change the address as well |
Contributor
|
will have to double check, but pretty sure this is fine. There aren't a ton of 1-byte messages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make can ignition hook v2 specific
having this increases the time it takes for v1 ignition shut off time