Fix PR #28: Rebase TypeScript receipt types and keep optional template-suite handling#29
Closed
Fix PR #28: Rebase TypeScript receipt types and keep optional template-suite handling#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ReceiptProtocolMetadataand wired it intoCommonsRequestEnvelopeandCommercialRequestEnvelopesox402/receiptmetadata is explicitly typed.CanonicalReceipttoCanonicalReceipt<TResult, TError>and propagated the generic result/error typing toCommandResponseandLegacyBlendedReceiptfor consistent typings.hashMatchesexplicitly, computereceipt_id_presentcorrectly, usesignerIdinternally and map it tovalues.signer_idin theVerifyResultoutput.extractReceiptVerbto use sharedgetReceiptVerblogic and enhancedgetReceiptVerbto fall back on common result-shape heuristics (e.g.,summary/analysis).typescript-sdk/scripts/template-tests.mjsto skip optional suites when no matching files exist while still running required suites.Testing
npm run typecheckintypescript-sdkand it completed successfully.npm run buildintypescript-sdkand the build completed successfully.npm run test:unitintypescript-sdkand all unit and template tests passed (44 passed, 0 failed).Codex Task