Final combined PR: merge #29 index.ts fixes with #30 template test fix#31
Closed
Final combined PR: merge #29 index.ts fixes with #30 template test fix#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
src/index.tsfixes (from PR Fix PR #28: Rebase TypeScript receipt types and keep optional template-suite handling #29) and the template test runner fix (from PR Fix template test discovery without node:fs globSync #30) are delivered together.globSyncfromnode:fsand instead enumerates test files in a portable way.Description
typescript-sdk/src/index.tstypes and plumbing by addingverb?:toCanonicalReceipt, introducingReceiptProtocolMetadata, and aligningCommandResponse/LegacyBlendedReceiptto useCanonicalReceipt<TResult>so generics and missing type names compile.receiptIdPresent, mappingsigner_idto thesignerIdlocal value, and changingextractReceiptVerbto usegetReceiptVerb(with a default of"summarize") so verb extraction is consistent with tests.typescript-sdk/scripts/template-tests.mjsto usereaddirSyncandpathto enumerate*.test.mjsfiles and pass explicit file paths tonode --test, removed any reliance onglobSync, and set a stablecwdfor test runs.Testing
cd typescript-sdk && npm run typecheckand TypeScript checks completed successfully.cd typescript-sdk && npm run buildand the package built successfully (ESM/CJS/DTS artifacts created).cd typescript-sdk && npm run test:unitand unit + template tests passed (unit suite: 44 passed, 0 failed; template tests: all subtests passed).Codex Task