Skip to content

Final combined PR: merge #29 index.ts fixes with #30 template test fix#31

Closed
GsCommand wants to merge 1 commit intomainfrom
codex/create-combined-pr-from-pr-#29
Closed

Final combined PR: merge #29 index.ts fixes with #30 template test fix#31
GsCommand wants to merge 1 commit intomainfrom
codex/create-combined-pr-from-pr-#29

Conversation

@GsCommand
Copy link
Copy Markdown
Contributor

Motivation

Description

  • Updated typescript-sdk/src/index.ts types and plumbing by adding verb?: to CanonicalReceipt, introducing ReceiptProtocolMetadata, and aligning CommandResponse / LegacyBlendedReceipt to use CanonicalReceipt<TResult> so generics and missing type names compile.
  • Fixed verification logic by introducing receiptIdPresent, mapping signer_id to the signerId local value, and changing extractReceiptVerb to use getReceiptVerb (with a default of "summarize") so verb extraction is consistent with tests.
  • Reworked typescript-sdk/scripts/template-tests.mjs to use readdirSync and path to enumerate *.test.mjs files and pass explicit file paths to node --test, removed any reliance on globSync, and set a stable cwd for test runs.
  • Kept changes minimal and focused on type/behavior fixes and test-runner portability without broader refactors.

Testing

  • Ran cd typescript-sdk && npm run typecheck and TypeScript checks completed successfully.
  • Ran cd typescript-sdk && npm run build and the package built successfully (ESM/CJS/DTS artifacts created).
  • Ran cd typescript-sdk && npm run test:unit and unit + template tests passed (unit suite: 44 passed, 0 failed; template tests: all subtests passed).

Codex Task

@GsCommand GsCommand closed this Apr 24, 2026
@GsCommand GsCommand deleted the codex/create-combined-pr-from-pr-#29 branch April 24, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant