feat(KR): add substitute holiday (대체공휴일) support - #641
Merged
Conversation
Add substitute-day rules for Children's Day, Independence Movement Day, Liberation Day, National Foundation Day, Hangul Day, Buddha's Birthday, Christmas Day and Constitution Day when they fall on a weekend, each effective from the year its substitute rule took legal effect. Seollal and Chuseok need separate explicit-date handling: their 3-day block can overlap either a Sunday or another public holiday, and the existing korean 01-0-01 P3D rule is anchored one day later than the real 전날/당일/다음날 window. Entries are computed from the corrected dates and cover 2014-2050. Closes commenthol#640
Owner
|
Many thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
korean 01-0-01 P3Drule for Seollal is anchored one day later than the real 전날/당일/다음날 window, so a rule computed against it directly would land on the wrong date. Entries are computed from the corrected window and cover 2014-2050 (see comment in the yaml for details/limitations).Test plan
npm run buildnpm test(regeneratedtest/fixtures/KR-*.json, full suite passing: 5373 tests)Closes #640