fix(SK): use official sources, fix Good Friday name, mark Easter Sunday as observance - #653
Merged
Merged
Conversation
Neither NBS nor sk.wikipedia list Easter Sunday itself as a "sviatok" or "deň pracovného pokoja" - only Good Friday and Easter Monday are called out, since Easter Sunday is always a Sunday anyway (already covered by dayoff: sunday). Mark it as observance to reflect that.
KristjanESPERANTO
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I swapped the
@attribfrom the Czech Wikipedia article to the Slovak one, since it's in the right language and links directly to the actual law (241/1993 Z.z.) behind these holidays. Added that law as a second reference too.While comparing against it and the National Bank's holiday page, I noticed Good Friday was translated as "Veľkonočný piatok" in
names.yaml- both sources agree it should be "Veľký piatok", so fixed that.Lastly, neither source lists Easter Sunday itself as a "sviatok" (holiday) or "deň pracovného pokoja" (non-working day) - only Good Friday and Easter Monday are called out, since Easter Sunday is always a Sunday anyway. Marked it as
observanceinstead of a statutory holiday to reflect that.