Mock rules JSON schema in tests and cancel state update on unmount - #1188
Draft
gciotola wants to merge 1 commit into
Draft
Mock rules JSON schema in tests and cancel state update on unmount#1188gciotola wants to merge 1 commit into
gciotola wants to merge 1 commit into
Conversation
✅ Deploy Preview for commercelayer-app-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1187
Problem
fetchJsonSchemawas performing a real network request tohttps://core.commercelayer.io/api/public/schemas/order_rules: no MSW handlerexisted, and that URL was explicitly excluded from the
onUnhandledRequestwarning in
src/mocks/setup.ts. Depending on network latency the promise couldresolve after the test file had finished, running
setOptionsConfigagainstan already torn-down jsdom environment.
Changes
src/mocks/data/core_schemas.ts(new): MSW handlers servingorder_rulesand
price_rulesfrom the local JSON files already present inRuleEngine/json_schema/, registered insrc/mocks/handlers.ts. No morenetwork calls in tests.
src/mocks/setup.ts: removed theonUnhandledRequestbypass for that URL,so unmocked requests are reported again.
RuleEngineComponent.tsx: the schema-parsing effect now returns a cleanupthat sets a
cancelledflag, preventing the state update after unmount. Thisis a general fix, relevant in production too on fast navigations.
Extra
If we want to keep testing against real API data, we can add the following test