Task/1 refactoring - #2
Open
mkcosta wants to merge 3 commits into
Open
Conversation
mkcosta
force-pushed
the
task/1_refactoring
branch
2 times, most recently
from
July 28, 2026 12:28
9992735 to
b01d1ac
Compare
- sign_charge now delegates to sign_authorize instead of duplicating its body; Stablecoins.eip3009_tokens/eip2612_tokens share a private tokens_supporting helper. - HttpClient#request: retry loop rewritten as an explicit while loop, the triplicated conditional log-field splat collapsed into one log() method, and the Net::HTTP request-class lookup hoisted into a frozen constant. - Eip3009Signature#to_hex now raises on malformed (non-0x-prefixed) r/s instead of silently producing a bad signature. - Added missing frozen_string_literal magic comments for consistency. - Stripped inline implementation comments, section dividers, and docs on private methods; public class/module/constant docs and YARD @param/@return blocks are untouched.
mkcosta
force-pushed
the
task/1_refactoring
branch
2 times, most recently
from
July 28, 2026 13:12
9421a72 to
5d5151b
Compare
mkcosta
force-pushed
the
task/1_refactoring
branch
from
July 28, 2026 13:13
5d5151b to
404de97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1