#186: Refactor all string-based statistics report message assertions …#216
Merged
heshamMassoud merged 29 commits intomasterfrom Dec 22, 2017
Merged
#186: Refactor all string-based statistics report message assertions …#216heshamMassoud merged 29 commits intomasterfrom
heshamMassoud merged 29 commits intomasterfrom
Conversation
…to counter assertions.
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=========================================
Coverage 93.06% 93.06%
Complexity 805 805
=========================================
Files 68 68
Lines 2077 2077
Branches 118 118
=========================================
Hits 1933 1933
Misses 123 123
Partials 21 21
Continue to review full report at Codecov.
|
…issingParents and it make it instance method.
andrii-kovalenko-ct
approved these changes
Dec 21, 2017
| assertThat(syncStatistics.getProcessed()).isEqualTo(5); | ||
| assertThat(syncStatistics.getCreated()).isEqualTo(4); | ||
| assertThat(syncStatistics.getUpdated()).isEqualTo(1); | ||
| assertThat(syncStatistics.getFailed()).isEqualTo(0); |
Contributor
There was a problem hiding this comment.
having so long similar assertThat() chains i'd make some util assertSyncStatistic() method, which accepts a statistic instance and a list of expected values.
Contributor
Author
lojzatran
approved these changes
Dec 21, 2017
# Conflicts: # docs/RELEASE_NOTES.md
…ic-assertion-class
…ic-assertion-class #186: create separate Assertor for sync statistic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#186
Todo