Conversation
🦋 Changeset detectedLatest commit: e7980e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ajimae
force-pushed
the
fix/reduce-token-fetch-window
branch
from
a680001 to
a7a1e27
Compare
briantomkins
left a comment
briantomkins
left a comment
There was a problem hiding this comment.
Thanks
Cant comment on the userOptions change. Expiration looks good
Codecov Report
@@ Coverage Diff @@
## master #1805 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 139 139
Lines 4854 4854
Branches 1328 1328
=======================================
Hits 4593 4593
Misses 258 258
Partials 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
Author
It's code formatting, let me revert it. Thanks |
ajimae
force-pushed
the
fix/reduce-token-fetch-window
branch
from
a7a1e27 to
16c070a
Compare
- reduce token fetch window from 2 hours to 5 minutes - add changeset to release changes
ajimae
force-pushed
the
fix/reduce-token-fetch-window
branch
from
16c070a to
e7980e5
Compare
jherey
approved these changes
Aug 23, 2022
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
Reduce the window period the SDK should fetch a new token to accommodate for the new 1 hours token validity period.
Related Issues
Jira