fix(http-user-agent): remove eval in favor of CSP compliant browser detection#480
Merged
Conversation
Contributor
|
Unit tests aren't passing |
Contributor
Author
Already on it. |
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
+ Coverage 98.57% 98.57% +<.01%
==========================================
Files 85 85
Lines 1899 1900 +1
Branches 463 464 +1
==========================================
+ Hits 1872 1873 +1
Misses 24 24
Partials 3 3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This relates to #479 and closes #479.
The browser detection was previously performed using a
new Functionwhich breaks harder CSP rules. Side note: jQuery also usednew Functionto parse JSON for a long time.Detecting the browser can be done in a mirage of ways. Often using an
evalornew Functionstatement. There are also packages likeglobal-or-windowwhich return the Node.JSglobalor thewindow. Something we don't specifically need.The new check is aligned with what we do at DOMPurify. Where we also had an issue filed around the same issue here.