Use YAML syntax for remote git location identification.#254
Merged
Conversation
As suggested by @greggwebs. The syntax proposed yesterday has the
advantage of concision, but using YAML syntax for the different
components adds marginal verbosity. As it is, the previous syntax made
extensibility problematic, whereas that's exactly where YAML
shines (what if we need an extra field to identify a particular git
commit?). Further, using YAML means people are free to include their own
metadata about package locations, without disturbing Stack.
Here's an example:
- location:
git: https://github.com/kolmodin/binary
commit: 8debedd3fcb6525ac0d7de2dd49217dce2abc0d9
Contributor
Author
Contributor
|
Properly pinging @gregwebs instead :) |
Member
|
Looks reasonable to me. |
snoyberg
added a commit
that referenced
this pull request
Jun 10, 2015
Use YAML syntax for remote git location identification.
Contributor
|
Me too, I agree on the reasoning as well. |
Contributor
|
Great!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @greggwebs. The syntax proposed yesterday has the
advantage of concision, but using YAML syntax for the different
components adds marginal verbosity. As it is, the previous syntax made
extensibility problematic, whereas that's exactly where YAML
shines (what if we need an extra field to identify a particular git
commit?). Further, using YAML means people are free to include their own
metadata about package locations, without disturbing Stack.
Here's an example:
Note that this patch removes the old syntax. The reasoning being -
custom user tooling would need to conservatively support both syntaxes
if there was a brief and a long syntax, because it can't assume that
other users utilized the easier to parse syntax.