Skip to content

Conversation

@markus1189
Copy link
Contributor

DRY up file resolver functions that only differ whether it's a file or directory by introducing internal helper functions.

@snoyberg snoyberg added this to the 0.2.0.0 milestone Jun 26, 2015
@snoyberg
Copy link
Contributor

Thanks! I'll leave to @chrisdone to review and comment on.

@markus1189 markus1189 force-pushed the reduce-duplication branch from 61565fb to 46e2133 Compare June 26, 2015 08:54
@markus1189
Copy link
Contributor Author

Hope I fixed the build error due to missing <$> import, I just replaced it with fmap instead of adding CPP.

@chrisdone
Copy link
Member

Looks good!

@markus1189 markus1189 force-pushed the reduce-duplication branch from 46e2133 to dbd9036 Compare June 26, 2015 10:16
chrisdone added a commit that referenced this pull request Jun 26, 2015
Reduce duplication in file resolver functions
@chrisdone chrisdone merged commit 7671eb2 into commercialhaskell:master Jun 26, 2015
@markus1189
Copy link
Contributor Author

There where still some missing Functor constraints for ghc < 7.10 ... I added them, let's see what travis says this time

@chrisdone
Copy link
Member

I already fixed it on master, no worries.

@markus1189
Copy link
Contributor Author

Awesome, funny how just using liftM in this case is better than fmap =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants