Adds KaOS support

[ShalokShalom]

See this: #5452

Is this something I am supposed to mention in the change.log?

Then I do it

[ShalokShalom]

I did a mistake and hardcoded that one, how can we detect the version of ghc-tinfo6 easily?

[ShalokShalom]

This line can only work when we soft code the version

[hasufell]

I don't think install scripts should ever do this. /usr/bin is controlled by your distros package manager.

Also note that there is a sudocmd function:

stack/etc/scripts/get-stack.sh

Line 138 in 708b516

sudocmd() {

[ShalokShalom]

So you suggest a different dir for the PATH?
And using sudocmd instead sudo?

[hasufell]

My opinion is to not do anything here. Global GHC installations is probably not in the scope the install script. IDEs like HLS work with stack just fine without exposing a global GHC.

[ShalokShalom]

its exactly what this script does for Debian and Co, no?

[ShalokShalom]

And vscode does not

[hasufell]

its exactly what this script does for Debian and Co, no?

I don't think so.

[mpilgrem]

I would like to resolve this pull request, one way or another. I am a Windows user, so forgive me if I take things step-by-step and ask questions that may seem obvious to a Linux user.

I understand that KaOS is a Linux distribution that is x86-64-specific, and kcp is a KaOS package manager. I also understand from the above that KaOS can use the generic Linux GHC binary, but needs kcp package libtinfo(https://kaos-community-packages.github.io/items/libtinfo.html) as a pre-requisite. Is that correct? Does KaOS not come with something that other Linux distributions provide as standard?

Other parts of the script (for other Linux distribtions) have things like this:

do_fedora_install() {
  install_dependencies() {
    dnf_install_pkgs perl make automake gcc gmp-devel libffi zlib-devel xz tar git gnupg
  }

  if is_x86_64 ; then
    install_dependencies "$1"
    print_bindist_notice
    install_x86_64_linux_binary
  else
    die "Sorry, currently only 64-bit (x86_64) Linux binary is available."
  fi
}

# Install packages using dnf
dnf_install_pkgs() {
  if ! sudocmd "install required system dependencies" dnf install -y ${QUIET:+-q} "$@"; then
    die "\nInstalling dnf packages failed.  Please run 'dnf check-update' and try again."
  fi
}

Should KaOS/kcp follow the same 'pattern' for its libtinfo need? What is it about libtinfo that a warning is required before it is installed?

Is libtinfo the only dependency that is required if the distribution is KaOS? Distributions such as Ubuntu and Fedora seem to have a list of things that are needed?

I wondered why KaOS is introduced via do_sloppy_install() and not as its own case "$DISTRO" in do_distro(), if it is now being catered for expressly?

The addition of a link in /usr/bin to a particular version of GHC in Stack's 'sandbox' looks wrong to me. If a KaOS user also wanted a specific version of GHC on the PATH (as well as the Stack-supplied ones), would they not just install it?

[ShalokShalom]

Wonderful 😄

Yes, you are basically correct about everything - the only thing I like to mention, is that libtinfo is build by the community and kcp is also a package manager for the community repo.

I only asked, if said dependency is fine to be added, since some people are quite sensitive about that.

I personally think its perfectly fine. 👍🏼

I love to introduce KaOS on the same level and with the same syntax as other distros, I think I was just to shy and hesitant to actually change something of the existing code.

You are also right about hard coding a specific version.

The only thing that is important to me, is to have an option to let the user choose to automatically add the compiler to the PATH.

Preferably, by scanning the sub directories, or simply by choosing the most recent version.

This way, people can just start coding. 🥳

[mpilgrem]

@ShalokShalom, I rebased on the master branch.

Some of my comments above were not apt - I was mislead by the way that the GitHub UI presented the changes in the file. I now understand that lines 425-427 are not part of do_sloppy_install().

I have:

• added a kcp_install_pkgs(). I could not find online any comprehensive documentation of the kcp command line interface. I hope I have understood how the command works. I got the impression that it can only install one package at a time.

• followed the pattern of other functions in do_kaos_install().

I am not in a position to test what I have done. Does the revised script actually work?

[ShalokShalom]

Sorry, I am not on KaOS anymore.

[mpilgrem]

I asked for testers on the Haskell Community but had no response. I am going to close this pull request. It can be reopened if another KaOS user and Haskeller emerges.

[ShalokShalom]

I just have no time at the moment. I tried to install KaOS in Virtualbox, but failed.

Will try if I find the time