Use dedicated JSON endpoint for snapshots#6874
Merged
Conversation
Closes #6871 For context on the changing API, see: * commercialhaskell/stackage-server#355 (initial change) * commercialhaskell/stackage-server#365 (bugfix for breaking Stack)
Member
Author
|
Hey actually I can add a CI test for the subcommand. Huh, I could also add an integration test at the stackage-server repo. Technology at work! |
Member
Author
|
The tests can be future work if you just want to merge this now. Actually, it would be a bad to add a test in stack, since a fault in Stackage shouldn't break the stack contribution workflow. So I won't do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6871
For context on the changing API, see:
Stackage website, snapshots page > 1 serves a json data stream instead of a normal webpage stackage-server#355 (initial change)
/snapshots api breaking change stackage-server#365 (bugfix for breaking Stack)
Any changes that could be relevant to users have been recorded in ChangeLog.md. (none)
The documentation has been updated, if necessary (none)
Testing
BEFORE:
AFTER: