Skip to content

Use dedicated JSON endpoint for snapshots#6874

Merged
mpilgrem merged 1 commit intomasterfrom
b/snapshots-json
Apr 13, 2026
Merged

Use dedicated JSON endpoint for snapshots#6874
mpilgrem merged 1 commit intomasterfrom
b/snapshots-json

Conversation

@chreekat
Copy link
Copy Markdown
Member

@chreekat chreekat commented Apr 13, 2026

Closes #6871

For context on the changing API, see:

Testing

BEFORE:

$ stack -- ls snapshots remote |& head -n2
JSONParseException Request {
  host                 = "www.stackage.org"

AFTER:

$ stack run stack -- ls snapshots remote |& head -n5
a month ago

Snapshot name: nightly-2026-03-14
Stackage Nightly 2026-03-14 (ghc-9.12.3)

Closes #6871

For context on the changing API, see:

* commercialhaskell/stackage-server#355
  (initial change)
* commercialhaskell/stackage-server#365
  (bugfix for breaking Stack)
@chreekat
Copy link
Copy Markdown
Member Author

Hey actually I can add a CI test for the subcommand.

Huh, I could also add an integration test at the stackage-server repo. Technology at work!

@chreekat
Copy link
Copy Markdown
Member Author

chreekat commented Apr 13, 2026

The tests can be future work if you just want to merge this now.

Actually, it would be a bad to add a test in stack, since a fault in Stackage shouldn't break the stack contribution workflow. So I won't do that.

@mpilgrem mpilgrem merged commit c5ca638 into master Apr 13, 2026
13 checks passed
@mpilgrem mpilgrem deleted the b/snapshots-json branch April 13, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stack ls snapshots remote should use new /api/v1/snapshots endpoint

2 participants