chore: remove dead code _find_check - #484
Conversation
_find_check in commit_check/util.py was no longer used by any production code. Only its tests in tests/util_test.py referenced it. Remove both the function and its corresponding test class.
✅ Deploy Preview for commit-check ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
==========================================
+ Coverage 97.20% 97.28% +0.07%
==========================================
Files 12 12
Lines 1182 1177 -5
==========================================
- Hits 1149 1145 -4
+ Misses 33 32 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 62.54%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_empty_message_passes |
1,217.2 µs | 748.9 µs | +62.54% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing chore/remove-dead-code-find-check (656e658) with main (ad606e1)
Footnotes
-
114 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩



Summary
_find_checkincommit_check/util.pyis no longer referenced by any production code. Only its tests intests/util_test.pystill called it — this is dead code.Changes
commit_check/util.py: Removed the_find_checkfunction definition (11 lines)tests/util_test.py: Removed the_find_checkimport and the entireTestHelperFunctionstest class (3 test methods)Verification
grep -rn "_find_check"confirms zero references outside of the deleted linesruff check/ruff format/mypyall passpython3 -m pytest -x -q)