167 add cache#177

Merged

sshi100 merged 9 commits into

mainfrom

Feb 12, 2021

sshi100 commented Feb 11, 2021

Contributor

No description provided.

sshi100 added 5 commits

February 5, 2021 01:10


          added cache

90dd5ce


          Merge remote-tracking branch 'origin/main' into 167-add-cache

944f071


          allow EKS worker to access cache store

e86bc33


          add cache service with template

923e895


          small fix

880f6ae

sshi100 requested a review from a team as a code owner

February 11, 2021 07:45

sshi100 commented Feb 11, 2021

Contributor Author

Waiting for commitdev/terraform-aws-zero#32 to be reviewed...

bmonkman reviewed

View reviewed changes

templates/terraform/environments/prod/main.tf Outdated

bmonkman reviewed

View reviewed changes

templates/terraform/environments/stage/main.tf

bmonkman reviewed

View reviewed changes

templates/terraform/environments/prod/main.tf Outdated

bmonkman reviewed

View reviewed changes

zero-module.yml Outdated

bmonkman suggested changes

View reviewed changes

bmonkman left a comment

Contributor

Requested changes


          updated after review

a141a44

bmonkman reviewed

View reviewed changes

templates/terraform/modules/environment/main.tf

bmonkman reviewed

View reviewed changes

templates/terraform/environments/prod/main.tf Outdated

bmonkman reviewed

View reviewed changes

templates/terraform/modules/environment/variables.tf Outdated

bmonkman reviewed

View reviewed changes

templates/terraform/modules/environment/variables.tf

sshi100 added 2 commits

February 11, 2021 16:09


          set default: no cache

9ad6d0a


          small fix

afe49dd

bmonkman reviewed

View reviewed changes

zero-module.yml Outdated


          a few changes after review

98158f0

bmonkman commented Feb 12, 2021

Contributor

There's an error in the tests during tf init:

Error: Unresolvable module version constraint

There is no available version of module "commitdev/zero/aws//modules/cache"
(../../modules/environment/main.tf:182) which matches the given version
constraint. The newest available version is 0.1.15.

bmonkman approved these changes

View reviewed changes

sshi100 self-assigned this

sshi100 mentioned this pull request

Add support for Elasticache Redis #167

Closed

sshi100 merged commit 667ac97 into main

sshi100 deleted the 167-add-cache branch

February 12, 2021 21:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet