Zero 131 add apply steps to makefile - #11
Merged
Merged
Conversation
bmonkman
reviewed
Jun 4, 2020
| run: | ||
| @echo Done | ||
| @echo "Set CIRCLECI environment variables\n" | ||
| curl -X POST --header "Content-Type: application/json" -d '{"name":"AWS_REGION", "value":"${AWS_REGION}"}' https://circleci.com/api/v1.1/project/github/${GITHUB_ORG}/${GITHUB_REPO}/envvar?circle-token=${CIRCLECI_TOKEN} |
Contributor
There was a problem hiding this comment.
These aren't quite the right env vars for this project. In the deploying with Zero doc it lists the env vars as:
AWS_ACCESS_KEY_ID
AWS_SECRET_ACCESS_KEY
SLACK_WEBHOOK
Contributor
Author
There was a problem hiding this comment.
We used the params needed by the sync command in the aws-s3 orb: https://circleci.com/orbs/registry/orb/circleci/aws-s3#commands-sync
We've also removed the dependency on SLACK_WEBHOOK for now because it wasn't being used anywhere.
bmonkman
approved these changes
Jun 4, 2020
bmonkman
reviewed
Jun 4, 2020
| @echo Done | ||
| @echo "Set CIRCLECI environment variables\n" | ||
| curl -X POST --header "Content-Type: application/json" -d '{"name":"AWS_REGION", "value":"${AWS_REGION}"}' https://circleci.com/api/v1.1/project/github/${GITHUB_ORG}/${GITHUB_REPO}/envvar?circle-token=${CIRCLECI_TOKEN} | ||
| curl -X POST --header "Content-Type: application/json" -d '{"name":"AWS_ACCESS_KEY", "value":"${AWS_ACCESS_KEY}"}' https://circleci.com/api/v1.1/project/github/${GITHUB_ORG}/${GITHUB_REPO}/envvar?circle-token=${CIRCLECI_TOKEN} |
Contributor
There was a problem hiding this comment.
Shouldn't this be called AWS_ACCESS_KEY_ID?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.