ZERO131 get aws and ci creds from secrets manager - #12
Merged
Conversation
bmonkman
reviewed
Jun 9, 2020
|
|
||
| AWS_ACCESS_KEY_ID := $(shell aws secretsmanager get-secret-value --secret-id=aws_access_key_id | jq -r '.SecretString') | ||
| AWS_SECRET_ACCESS_KEY := $(shell aws secretsmanager get-secret-value --secret-id=aws_secret_access_key | jq -r '.SecretString') | ||
| CIRCLECI_TOKEN := $(shell aws secretsmanager get-secret-value --secret-id=circleci_api_key | jq -r '.SecretString') |
Contributor
There was a problem hiding this comment.
The circle token should be passed in as an env var to make
bmonkman
reviewed
Jun 9, 2020
| # - CIRCLECI_TOKEN | ||
| # | ||
|
|
||
| AWS_ACCESS_KEY_ID := $(shell aws secretsmanager get-secret-value --secret-id=aws_access_key_id | jq -r '.SecretString') |
Contributor
There was a problem hiding this comment.
Sorry, just realized this secret has json inside it. So these should be:
... --secret-id=ci-user-aws-keys | jq -r '.SecretString'| jq -r .access_key_id
... --secret-id=ci-user-aws-keys | jq -r '.SecretString'| jq -r .secret_key
Contributor
Author
There was a problem hiding this comment.
I will make these changes to the backend Makefile as well.
bmonkman
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.