Added features necessary to support the new zero apply command - #14
Merged
Conversation
Added parsing of repository var
cjhawkins
reviewed
Jun 23, 2020
| curl -X POST --header "Content-Type: application/json" -d '{"name":"AWS_ACCESS_KEY_ID", "value":"${AWS_ACCESS_KEY_ID}"}' https://circleci.com/api/v1.1/project/github/${GITHUB_ORG}/${GITHUB_REPO}/envvar?circle-token=${CIRCLECI_TOKEN} | ||
| curl -X POST --header "Content-Type: application/json" -d '{"name":"AWS_SECRET_ACCESS_KEY", "value":"${AWS_SECRET_ACCESS_KEY}"}' https://circleci.com/api/v1.1/project/github/${GITHUB_ORG}/${GITHUB_REPO}/envvar?circle-token=${CIRCLECI_TOKEN} | ||
| curl -X POST --header "Content-Type: application/json" -d '{"name":"AWS_ACCESS_KEY_ID", "value":"${AWS_ACCESS_KEY_ID}"}' https://circleci.com/api/v1.1/project/github/${GITHUB_ORG}/${GITHUB_REPO}/envvar?circle-token=${CIRCLECI_API_KEY} | ||
| curl -X POST --header "Content-Type: application/json" -d '{"name":"AWS_SECRET_ACCESS_KEY", "value":"${AWS_SECRET_ACCESS_KEY}"}' https://circleci.com/api/v1.1/project/github/${GITHUB_ORG}/${GITHUB_REPO}/envvar?circle-token=${CIRCLECI_API_KEY} |
Contributor
There was a problem hiding this comment.
Are AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY passed in as args now?
Contributor
Author
There was a problem hiding this comment.
Oops, no. Just missed that they were referenced in there. Added them back in.
cjhawkins
approved these changes
Jun 24, 2020
davidcheung
reviewed
Jun 24, 2020
| default: api. | ||
| - field: randomSeed | ||
| label: Random seed that will be shared between projects to come up with deterministic resource names | ||
| execute: uuidgen |
Contributor
There was a problem hiding this comment.
uuidgen actually gives a pretty long name(36chars), alot of AWS artifacts have character limit we might not be able to use it :(
Contributor
There was a problem hiding this comment.
not sure what's a good alternative... crc32 <(uuidgen) ?
Contributor
Author
There was a problem hiding this comment.
Or just uuidgen | head -c 8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added parsing of repository var