Skip to content

User login - #27

Merged
davidcheung merged 3 commits into
mainfrom
user-login
Nov 13, 2020
Merged

User login#27
davidcheung merged 3 commits into
mainfrom
user-login

Conversation

@davidcheung

@davidcheung davidcheung commented Oct 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • router
  • 404 page
  • authForms
  • navigation with auth
  • dashboard page with auth only
  • auth logic with kratos
    • register
    • login
    • logout
    • forgot password
    • profile
  • comments to explain how to tie kratos in with oidc
    - [ ] where to sign up for google/github oauth etc probably should be just infra's readme
    • comments explaining what different endpoints
      • public auth endpoints (used for self-service/auth and sessions/whoami)
      • backend authenticated endpoints (used for application logic )
      • backend public endpoints (used for public api calls eg. pod info we show at the main page)

@davidcheung
davidcheung marked this pull request as ready for review November 10, 2020 02:14
@davidcheung
davidcheung requested a review from a team November 10, 2020 18:47
@davidcheung
davidcheung merged commit 28c5240 into main Nov 13, 2020
@davidcheung
davidcheung deleted the user-login branch November 13, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@bmonkman bmonkman bmonkman approved these changes
@superkhau superkhau superkhau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidcheung @bmonkman @superkhau