Skip to content

Added missing header name to signing error message#11

Merged
chrnorm merged 1 commit into
common-fate:mainfrom
micahhausler:sigbase-debug
Nov 12, 2024
Merged

Added missing header name to signing error message#11
chrnorm merged 1 commit into
common-fate:mainfrom
micahhausler:sigbase-debug

Conversation

@micahhausler

Copy link
Copy Markdown
Contributor

The current error if a request is missing a required header is:

deriving signature base: identifier "": HTTP header was empty

This change adds the missing component name, to ease debugging of a missing identifier

deriving signature base: identifier "content-type" "": HTTP header was empty

@chrnorm chrnorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou @micahhausler!

@chrnorm chrnorm merged commit da269ba into common-fate:main Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants