Skip to content

Fix spawnPattern data handling [CT-910] #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
+87 −45
Merged

Fix spawnPattern data handling [CT-910] #1796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f83ee4
Fix `spawnPattern` data handling
bfollington Sep 18, 2025
20463e5
Clean up Charm types
bfollington Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions packages/patterns/chatbot-note.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ import {

import Chat from "./chatbot.tsx";

type Charm = {
export type MentionableCharm = {
[NAME]: string;
content?: string;
mentioned?: Charm[];
mentioned?: MentionableCharm[];
};

type NoteResult = {
Expand All @@ -38,13 +38,13 @@ type NoteResult = {

export type NoteInput = {
content: Default<string, "">;
allCharms: Cell<Charm[]>;
allCharms: Cell<MentionableCharm[]>;
};

const handleCharmLinkClick = handler<
{
detail: {
charm: Cell<Charm>;
charm: Cell<MentionableCharm>;
};
},
Record<string, never>
Expand Down Expand Up @@ -72,7 +72,7 @@ export const Note = recipe<NoteInput>(
);

const handleCharmLinkClicked = handler(
(_: any, { charm }: { charm: Cell<Charm> }) => {
(_: any, { charm }: { charm: Cell<MentionableCharm> }) => {
return navigateTo(charm);
},
);
Expand All @@ -82,13 +82,13 @@ type LLMTestInput = {
messages: Default<Array<BuiltInLLMMessage>, []>;
expandChat: Default<boolean, false>;
content: Default<string, "">;
allCharms: Cell<Charm[]>;
allCharms: Cell<MentionableCharm[]>;
};

type LLMTestResult = {
messages: Default<Array<BuiltInLLMMessage>, []>;
mentioned: Default<Array<Charm>, []>;
backlinks: Default<Array<Charm>, []>;
mentioned: Default<Array<MentionableCharm>, []>;
backlinks: Default<Array<MentionableCharm>, []>;
content: Default<string, "">;
};

Expand Down Expand Up @@ -163,7 +163,7 @@ export default recipe<LLMTestInput, LLMTestResult>(
const chat = Chat({ messages, tools });
const { addMessage, cancelGeneration, pending } = chat;

const mentioned = cell<Charm[]>([]);
const mentioned = cell<MentionableCharm[]>([]);

// Must use JSONSchema here, CTS doesn't work correctly. See CT-901
const computeBacklinks = lift(
Expand All @@ -179,7 +179,7 @@ export default recipe<LLMTestInput, LLMTestResult>(
items: { type: "object" },
} as JSONSchema,
({ allCharms, content }) => {
const cs: Charm[] = allCharms.get();
const cs: MentionableCharm[] = allCharms.get();
if (!cs) return [];

const self = cs.find((c) => c.content === content.get());
Expand All @@ -194,7 +194,7 @@ export default recipe<LLMTestInput, LLMTestResult>(
},
);

const backlinks: OpaqueRef<Charm[]> = computeBacklinks({
const backlinks: OpaqueRef<MentionableCharm[]> = computeBacklinks({
allCharms,
content,
});
Expand Down Expand Up @@ -230,7 +230,7 @@ export default recipe<LLMTestInput, LLMTestResult>(
<details>
<summary>Mentioned Charms</summary>
<ct-vstack>
{mentioned.map((charm: Charm) => (
{mentioned.map((charm: MentionableCharm) => (
<ct-button onClick={handleCharmLinkClicked({ charm })}>
{charm[NAME]}
</ct-button>
Expand All @@ -240,7 +240,7 @@ export default recipe<LLMTestInput, LLMTestResult>(
<details>
<summary>Backlinks</summary>
<ct-vstack>
{backlinks.map((charm: Charm) => (
{backlinks.map((charm: MentionableCharm) => (
<ct-button onClick={handleCharmLinkClicked({ charm })}>
{charm[NAME]}
</ct-button>
Expand Down
106 changes: 74 additions & 32 deletions packages/patterns/default-app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
handler,
NAME,
navigateTo,
OpaqueRef,
recipe,
str,
UI,
Expand All @@ -16,8 +17,11 @@ import {
import Chatbot from "./chatbot.tsx";
import ChatbotTools from "./chatbot-tools.tsx";
import ChatbotOutliner from "./chatbot-outliner.tsx";
import ChatbotNote from "./chatbot-note.tsx";
import Note from "./note.tsx";
import {
default as ChatbotNote,
type MentionableCharm,
} from "./chatbot-note.tsx";
import { default as Note } from "./note.tsx";

export type Charm = {
[NAME]?: string;
Expand Down Expand Up @@ -61,11 +65,64 @@ const removeCharm = handler<
}
});

const spawnPattern = (recipe: any, params: any) =>
handler<Record<string, never>, Record<string, never>>((event, state) => {
const charm = recipe(params);
return navigateTo(charm);
});
const spawnChatbot = handler<
Record<string, never>,
Record<string, never>
>((_, state) => {
return navigateTo(Chatbot({
messages: [],
tools: undefined,
}));
});

const spawnChatbotTools = handler<
Record<string, never>,
Record<string, never>
>((_, state) => {
return navigateTo(ChatbotTools({
title: "Chatbot Tools",
messages: [],
list: [],
}));
});

const spawnChatbotOutliner = handler<
Record<string, never>,
{ allCharms: Cell<Charm[]> }
>((_, state) => {
return navigateTo(ChatbotOutliner({
title: "Chatbot Outliner",
expandChat: false,
messages: [],
outline: {
root: { body: "", children: [], attachments: [] },
},
allCharms: state.allCharms,
}));
});

const spawnChatbotNote = handler<
Record<string, never>,
{ allCharms: Cell<MentionableCharm[]> }
>((_, state) => {
return navigateTo(ChatbotNote({
title: "New Note",
content: "",
expandChat: false,
messages: [],
allCharms: state.allCharms,
}));
});

const spawnNote = handler<
Record<string, never>,
Record<string, never>
>((_, state) => {
return navigateTo(Note({
title: "New Note",
content: "",
}));
});

export default recipe<CharmsListInput, CharmsListOutput>(
"DefaultCharmList",
Expand All @@ -79,47 +136,32 @@ export default recipe<CharmsListInput, CharmsListOutput>(
<ct-hstack gap="2" align="center">
<h3>Quicklaunch:</h3>
<ct-button
onClick={spawnPattern(Chatbot, {
messages: [],
tools: undefined,
})({})}
onClick={spawnChatbot({})}
>
💬 Chatbot
</ct-button>
<ct-button
onClick={spawnPattern(ChatbotTools, {
title: "Chatbot Tools",
chat: [],
list: [],
})({})}
onClick={spawnChatbotTools({})}
>
🔧 Chatbot Tools
</ct-button>
<ct-button
onClick={spawnPattern(ChatbotOutliner, {
outline: {
root: { body: "", children: [], attachments: [] },
},
allCharms,
})({})}
onClick={spawnChatbotOutliner({ allCharms })}
>
📝 Chatbot Outliner
</ct-button>
<ct-button
onClick={spawnPattern(ChatbotNote, {
title: "New Note",
content: "",
allCharms,
})({})}
onClick={spawnChatbotNote({
// slight disagreement between Charm types but they are compatible
allCharms: allCharms as unknown as OpaqueRef<
MentionableCharm[]
>,
})}
>
🤖 Chatbot Note
</ct-button>
<ct-button
onClick={spawnPattern(Note, {
title: "New Note",
content: "",
allCharms,
})({})}
onClick={spawnNote({})}
>
📄 Note
</ct-button>
Expand Down