Skip to content

Conversation

@jsantell
Copy link
Collaborator

@jsantell jsantell commented Nov 14, 2025

Summary by cubic

Removed redundant workspace import aliases and flattened schema-generator export paths to normalize module resolution and reduce cross-package coupling.

  • Refactors

    • Root deno.json: removed "@commontools/schema-generator/cell-brand" import alias.
    • schema-generator: exports changed from "./typescript/*" to "./cell-brand" and "./type-traversal"; removed unused imports to utils/static.
    • ts-transformers: removed import alias for "@commontools/schema-generator/cell-brand".
  • Migration

    • Update imports from "@commontools/schema-generator/typescript/cell-brand" to "@commontools/schema-generator/cell-brand".
    • Update imports from "@commontools/schema-generator/typescript/type-traversal" to "@commontools/schema-generator/type-traversal".

Written for commit 4057043. Summary will update automatically on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 3 files

Prompt for AI agents (all 2 issues)

Understand the root cause of the following 2 issues and fix them.


<file name="packages/schema-generator/deno.json">

<violation number="1" location="packages/schema-generator/deno.json:11">
Removing the import-map entry for &quot;@commontools/utils&quot; leaves the existing imports unresolved when Deno loads this package. Please keep the mapping so the &quot;@commontools/utils/*&quot; imports continue to resolve.</violation>
</file>

<file name="packages/ts-transformers/deno.json">

<violation number="1" location="packages/ts-transformers/deno.json:10">
Dropping the @commontools/schema-generator/cell-brand import map entry leaves files such as src/transformers/opaque-ref/opaque-ref.ts unable to resolve that specifier when run under Deno. Please keep the mapping or update the import to point at a resolvable source.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

"typescript": "npm:typescript",
"@commontools/utils": "../utils/src/index.ts",
"@commontools/static": "../static/index.ts"
"typescript": "npm:typescript"
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the import-map entry for "@commontools/utils" leaves the existing imports unresolved when Deno loads this package. Please keep the mapping so the "@commontools/utils/*" imports continue to resolve.

Prompt for AI agents
Address the following comment on packages/schema-generator/deno.json at line 11:

<comment>Removing the import-map entry for &quot;@commontools/utils&quot; leaves the existing imports unresolved when Deno loads this package. Please keep the mapping so the &quot;@commontools/utils/*&quot; imports continue to resolve.</comment>

<file context>
@@ -4,13 +4,11 @@
-    &quot;typescript&quot;: &quot;npm:typescript&quot;,
-    &quot;@commontools/utils&quot;: &quot;../utils/src/index.ts&quot;,
-    &quot;@commontools/static&quot;: &quot;../static/index.ts&quot;
+    &quot;typescript&quot;: &quot;npm:typescript&quot;
   },
   &quot;tasks&quot;: {
</file context>
Fix with Cubic

"imports": {
"typescript": "npm:typescript",
"@commontools/schema-generator/cell-brand": "../schema-generator/src/typescript/cell-brand.ts"
"typescript": "npm:typescript"
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the @commontools/schema-generator/cell-brand import map entry leaves files such as src/transformers/opaque-ref/opaque-ref.ts unable to resolve that specifier when run under Deno. Please keep the mapping or update the import to point at a resolvable source.

Prompt for AI agents
Address the following comment on packages/ts-transformers/deno.json at line 10:

<comment>Dropping the @commontools/schema-generator/cell-brand import map entry leaves files such as src/transformers/opaque-ref/opaque-ref.ts unable to resolve that specifier when run under Deno. Please keep the mapping or update the import to point at a resolvable source.</comment>

<file context>
@@ -7,8 +7,7 @@
   &quot;imports&quot;: {
-    &quot;typescript&quot;: &quot;npm:typescript&quot;,
-    &quot;@commontools/schema-generator/cell-brand&quot;: &quot;../schema-generator/src/typescript/cell-brand.ts&quot;
+    &quot;typescript&quot;: &quot;npm:typescript&quot;
   },
   &quot;tasks&quot;: {
</file context>
Fix with Cubic

@jsantell jsantell merged commit 88bfdaf into main Nov 14, 2025
9 checks passed
@jsantell jsantell deleted the normalize-manifest-exports branch November 14, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants