-
Notifications
You must be signed in to change notification settings - Fork 11
chore: Remove redundant workspace imports #2077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 3 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="packages/schema-generator/deno.json">
<violation number="1" location="packages/schema-generator/deno.json:11">
Removing the import-map entry for "@commontools/utils" leaves the existing imports unresolved when Deno loads this package. Please keep the mapping so the "@commontools/utils/*" imports continue to resolve.</violation>
</file>
<file name="packages/ts-transformers/deno.json">
<violation number="1" location="packages/ts-transformers/deno.json:10">
Dropping the @commontools/schema-generator/cell-brand import map entry leaves files such as src/transformers/opaque-ref/opaque-ref.ts unable to resolve that specifier when run under Deno. Please keep the mapping or update the import to point at a resolvable source.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| "typescript": "npm:typescript", | ||
| "@commontools/utils": "../utils/src/index.ts", | ||
| "@commontools/static": "../static/index.ts" | ||
| "typescript": "npm:typescript" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the import-map entry for "@commontools/utils" leaves the existing imports unresolved when Deno loads this package. Please keep the mapping so the "@commontools/utils/*" imports continue to resolve.
Prompt for AI agents
Address the following comment on packages/schema-generator/deno.json at line 11:
<comment>Removing the import-map entry for "@commontools/utils" leaves the existing imports unresolved when Deno loads this package. Please keep the mapping so the "@commontools/utils/*" imports continue to resolve.</comment>
<file context>
@@ -4,13 +4,11 @@
- "typescript": "npm:typescript",
- "@commontools/utils": "../utils/src/index.ts",
- "@commontools/static": "../static/index.ts"
+ "typescript": "npm:typescript"
},
"tasks": {
</file context>
| "imports": { | ||
| "typescript": "npm:typescript", | ||
| "@commontools/schema-generator/cell-brand": "../schema-generator/src/typescript/cell-brand.ts" | ||
| "typescript": "npm:typescript" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropping the @commontools/schema-generator/cell-brand import map entry leaves files such as src/transformers/opaque-ref/opaque-ref.ts unable to resolve that specifier when run under Deno. Please keep the mapping or update the import to point at a resolvable source.
Prompt for AI agents
Address the following comment on packages/ts-transformers/deno.json at line 10:
<comment>Dropping the @commontools/schema-generator/cell-brand import map entry leaves files such as src/transformers/opaque-ref/opaque-ref.ts unable to resolve that specifier when run under Deno. Please keep the mapping or update the import to point at a resolvable source.</comment>
<file context>
@@ -7,8 +7,7 @@
"imports": {
- "typescript": "npm:typescript",
- "@commontools/schema-generator/cell-brand": "../schema-generator/src/typescript/cell-brand.ts"
+ "typescript": "npm:typescript"
},
"tasks": {
</file context>
Summary by cubic
Removed redundant workspace import aliases and flattened schema-generator export paths to normalize module resolution and reduce cross-package coupling.
Refactors
Migration
Written for commit 4057043. Summary will update automatically on new commits.