Skip to content

chore: Remove redundant workspace imports #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

chore: Remove redundant workspace imports #2077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions deno.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@
"merkle-reference": "npm:merkle-reference@^2.2.0",
"multiformats": "npm:multiformats@^13.3.2",
"turndown": "npm:turndown@^7.1.2",
"zod": "npm:zod@^3.24.1",
"@commontools/schema-generator/cell-brand": "./packages/schema-generator/src/typescript/cell-brand.ts"
"zod": "npm:zod@^3.24.1"
}
}
8 changes: 3 additions & 5 deletions packages/schema-generator/deno.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@
"exports": {
".": "./src/index.ts",
"./interface": "./src/interface.ts",
"./typescript/cell-brand": "./src/typescript/cell-brand.ts",
"./typescript/type-traversal": "./src/typescript/type-traversal.ts"
"./cell-brand": "./src/typescript/cell-brand.ts",
"./type-traversal": "./src/typescript/type-traversal.ts"
},
"imports": {
"typescript": "npm:typescript",
"@commontools/utils": "../utils/src/index.ts",
"@commontools/static": "../static/index.ts"
"typescript": "npm:typescript"
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Nov 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the import-map entry for "@commontools/utils" leaves the existing imports unresolved when Deno loads this package. Please keep the mapping so the "@commontools/utils/*" imports continue to resolve.

Prompt for AI agents 
Address the following comment on packages/schema-generator/deno.json at line 11:

<comment>Removing the import-map entry for &quot;@commontools/utils&quot; leaves the existing imports unresolved when Deno loads this package. Please keep the mapping so the &quot;@commontools/utils/*&quot; imports continue to resolve.</comment>

<file context>
@@ -4,13 +4,11 @@
-    &quot;typescript&quot;: &quot;npm:typescript&quot;,
-    &quot;@commontools/utils&quot;: &quot;../utils/src/index.ts&quot;,
-    &quot;@commontools/static&quot;: &quot;../static/index.ts&quot;
+    &quot;typescript&quot;: &quot;npm:typescript&quot;
   },
   &quot;tasks&quot;: {
</file context>
Fix with Cubic

},
"tasks": {
"test": "deno test --allow-read --allow-write --allow-run --allow-env=API_URL,\"TSC_*\",NODE_INSPECTOR_IPC,VSCODE_INSPECTOR_OPTIONS,NODE_ENV,UPDATE_GOLDENS test/**/*.test.ts",
Expand Down
3 changes: 1 addition & 2 deletions packages/ts-transformers/deno.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
"./core/imports": "./src/core/imports.ts"
},
"imports": {
"typescript": "npm:typescript",
"@commontools/schema-generator/cell-brand": "../schema-generator/src/typescript/cell-brand.ts"
"typescript": "npm:typescript"
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Nov 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the @commontools/schema-generator/cell-brand import map entry leaves files such as src/transformers/opaque-ref/opaque-ref.ts unable to resolve that specifier when run under Deno. Please keep the mapping or update the import to point at a resolvable source.

Prompt for AI agents 
Address the following comment on packages/ts-transformers/deno.json at line 10:

<comment>Dropping the @commontools/schema-generator/cell-brand import map entry leaves files such as src/transformers/opaque-ref/opaque-ref.ts unable to resolve that specifier when run under Deno. Please keep the mapping or update the import to point at a resolvable source.</comment>

<file context>
@@ -7,8 +7,7 @@
   &quot;imports&quot;: {
-    &quot;typescript&quot;: &quot;npm:typescript&quot;,
-    &quot;@commontools/schema-generator/cell-brand&quot;: &quot;../schema-generator/src/typescript/cell-brand.ts&quot;
+    &quot;typescript&quot;: &quot;npm:typescript&quot;
   },
   &quot;tasks&quot;: {
</file context>
Fix with Cubic

},
"tasks": {
"test": "deno test --allow-read --allow-write --allow-env test/**/*.test.ts",
Expand Down