Homebridge script does NOT install into a container

[bazfum]

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

install/homebridge-install.sh

📂 What was the exact command used to execute the script?

homebridge-install.sh

⚙️ What settings are you using?

• Default Settings
• Advanced Settings

🖥️ Which Linux distribution are you using?

No response

📝 Provide a clear and concise description of the issue.

This script does NOT create a container but instead just installs Homebridge on the host OS. I know I should have read through it more closely but the description on the site does say it creates a container.

🔄 Steps to reproduce the issue.

run command in your proxmox shell, see install right there

❌ Paste the full error output (if available).

n/a

🖼️ Additional context (optional).

No response

[michelroegl-brunner]

I dont really know what you are doing but it creates the LXC just fine?

You used this command bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/homebridge.sh)"?

[bazfum]

Nope, it did not show any of the info there and just ran all the app-get etc commands right on the host.

[MickLesk]

Screenshot?

[michelroegl-brunner]

Nope, it did not show any of the info there and just ran all the app-get etc commands right on the host.

If you used pur script (the one i posted above) this is technical not even possible, as the script would fail befor even running the apt command, as this is run directly with the Container ID. And if it was not created, it would not be started and fail there.

The only thing wich gets installed with apt on your host is curl, maybee you saw that?

Can you please provide the exact command you used?

[tremor021]

So, basically the website says "run this command to install", but you went ahead add ignored it and did it the way YOU want to do it?

Man...

[bazfum]

I ran the script, it never gave any of that colorful information. On the host, it ran the exact commands listed in the script file. Installed avahi and gnupg, then added the homebridge repository and installed homeridge.

When I realized what happened I immediately cleaned it up to avoid interfering with VMs running in the host.

I don’t see any error handling in that script, so I just have to assume that source command at the top failed and it just kept on going where it was.

[MickLesk]

If you run this on the host, it will of course only be installed on the host... If you don't get any feedback despite curl, something is wrong. Curl has its own error handling

[michelroegl-brunner]

I ran the script, it never gave any of that colorful information. On the host, it ran the exact commands listed in the script file. Installed avahi and gnupg, then added the homebridge repository and installed homeridge.

When I realized what happened I immediately cleaned it up to avoid interfering with VMs running in the host.

I don’t see any error handling in that script, so I just have to assume that source command at the top failed and it just kept on going where it was.

To be fair, and i dont want to offend you, you should never execute shell code from the web when you can not comprehend it. Wich is okay, this is the main reason this repository even exist.
Bit blindly executing shell commands is dangerous, and you should never do it.

I will close this issue now, as this is not a issue with our script. Please run the script again and if any error occours, or even you get no output at all, pleas open a new issue for this.

And pleas, never execute commands you dont understand blindly in your shell. Our code is maintained and everey pull request needs approval from two persons. But not everey code you find online has this much scrunity. Either it can be mallicious or destroy your Operating System.

[bazfum]

How else is it supposed to create a container if you don’t run it on the host? Every other script I’ve run from this site runs in the host shell, why would this be different? It says it’s going to create a container and then run the install in the container. It didn’t do that. That’s a bug.

[michelroegl-brunner]

Yeah, just run the provided command from the homepage.
Do not run the code lines by itself, as there is so much automation it breaks.

I tried it yesterday on my private node (screenshot above) and tody on my test node at work, it creates the container just fine.

Maybe try debian, and if it works try homebridge again.

[bazfum]

Again, I did just run the script. In the host shell in the PM admin site. It didn’t create a container. It just installed directly on the host shell. There is no error handling in that to ensure that those PM specific commands actually run, so I have to assume that sourcing failed and it just kept going. I have run several other scripts exactly the same way and they worked. Maybe it was just a glitch, but the lack of error handling is still a bug.

[michelroegl-brunner]

And above you stated you ran the commands line by line after the script failed, now you say you did not do anything. (wich has propper error handeling, but only after the source command).
It would fail when it can not source because the functions are defined in the sourced build.func

[bazfum]

I never said I ran them line by line? No idea where you got that from. The only error handling I see is around the homebridge install pieces, nothing’s looking to make sure it created and entered a container.