Use Proxmox for a template before reaching for linuxcontainers.org - #23
Open
MickLesk wants to merge 3 commits into
Open
Use Proxmox for a template before reaching for linuxcontainers.org#23MickLesk wants to merge 3 commits into
MickLesk wants to merge 3 commits into
Conversation
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/feat/pveam-first-template-lookup \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/ct/debian.sh)"Swap This PR touches both backends. Worth running on a Proxmox VE and an Incus host. Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/feat/pveam-first-template-lookup/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/ProxmoxVED/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/feat/pveam-first-template-lookupNote that Useful flags while testing
|
Every ARM64 container took the custom-template path, so pveam was never consulted on that architecture. For Debian that path resolved its URL from community-scripts/debian-arm64-lxc, a repository that does not exist: the releases endpoint answers 404, so ARM64 Debian could not be created at all through the split core. Template lookup now runs the same way on both architectures. Local templates first, then the catalog, both matched on OS, version and exact architecture. Only when Proxmox has nothing does the linuxcontainers.org build step in, which is still the only source for Ubuntu, Fedora and the rest on ARM64. Against a live catalog this routes debian 13 and alpine 3.24 through pveam on ARM64 -- Proxmox ships both -- while debian 12, ubuntu and fedora keep the old path. A local template short-circuits before any catalog read. The interactive "pick another version" fallback filtered by name only. On a host whose catalog carries both architectures, which is now the normal case, it could offer an amd64 template to an ARM64 host and fail later at creation. Supersedes the Debian-only routing in #5.
MickLesk
force-pushed
the
feat/pveam-first-template-lookup
branch
from
September 4, 2026 07:24
a6d3e2b to
400905e
Compare
Image resolution tried up to six images: candidates over the network before looking at what was already copied locally, so an image on disk still cost round-trips and resolution failed outright on a host without internet. The local match was also a substring search over the whole CSV row: asking for debian/12 matched a debian/13 row uploaded on 2026/12/01, because the row contains "debian" and the date contains "12". That launched the wrong release with no error. It now compares the alias field whole.
Member
Author
@asylumexp fyi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


✍️ Description
Every ARM64 container took the custom-template path, so pveam was never consulted on that architecture.
-> Template lookup now runs the same way on both architectures: local templates first, then the catalog, both matched on OS, version and exact architecture. Only when Proxmox has nothing does linuxcontainers.org step in, which is still the only source for Ubuntu, Fedora and the rest on ARM64.
The interactive "pick another version" fallback matched by name only, so on a host whose catalog carries both architectures — now the normal case — it could offer an amd64 template to an ARM64 host.
🔗 Related Issue
Refs #5
✅ Prerequisites (X in brackets)
pveam availablecatalog; not run on an ARM64 host.API.txt.🤖 AI Assistance (X in brackets)
🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.