Skip to content

Move MAGMA, LAVA, ldblock to comorment/magma repo#100

Merged
ofrei merged 4 commits intomainfrom
split_out_magma
Nov 30, 2022
Merged

Move MAGMA, LAVA, ldblock to comorment/magma repo#100
ofrei merged 4 commits intomainfrom
split_out_magma

Conversation

@ofrei
Copy link
Contributor

@ofrei ofrei commented Nov 30, 2022

Fixes #54

Changes proposed in this pull request:

  • MAGMA, LAVA and ldblock software is moved to https://github.com/comorment/magma. MAGMA reference files are also moved to this repository.
  • unit-tests are implemented in https://github.com/comorment/magma , and they are working just fine. Update Dockerfile and a newly build .sif file is also included in that repo. The new repo still needs better documentation, but this I can address later.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@ofrei ofrei requested a review from espenhgn November 30, 2022 12:13
Copy link
Contributor

@espenhgn espenhgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just go ahead with the merge.

@ofrei ofrei merged commit 0ccb985 into main Nov 30, 2022
@ofrei ofrei deleted the split_out_magma branch November 30, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move MAGMA and LAVA into its own github repository

2 participants