Deepchocolate/ldpred2 updates fixes#122
Merged
deepchocolate merged 3 commits intodeepchocolate/ldpred2_ldfrom Feb 1, 2023
Merged
Deepchocolate/ldpred2 updates fixes#122deepchocolate merged 3 commits intodeepchocolate/ldpred2_ldfrom
deepchocolate merged 3 commits intodeepchocolate/ldpred2_ldfrom
Conversation
espenhgn
changed the base branch from
deepchocolate/ldpred2_updates
to
deepchocolate/ldpred2_ld
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @deepchocolate. Just some minor fixes and readme updates to PR #117.
The main change is a flag for the field separator in the sumstats file in the calculateLD.R script.
I chose whitespace-separated, but don't know if this is the best choice, as the sumstats_specification doesn't mention what to expect.
read.tabledoesn't automatically choose a suitable separator.Couldn't run the README's height example(s) on the nrec devbox due to memory constraints, but assume all is well.