Skip to content

Reformat gwas.py and combine_figures.py #128

Merged
espenhgn merged 4 commits intomainfrom
fix-127
Feb 10, 2023
Merged

Reformat gwas.py and combine_figures.py #128
espenhgn merged 4 commits intomainfrom
fix-127

Conversation

@ofrei
Copy link
Contributor

@ofrei ofrei commented Feb 9, 2023

Fixes #127

Changes proposed in this pull request:

  • formatted python scripts to better comply with the style guide

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@ofrei ofrei changed the title Fix 127 Reformat gwas.py and combine_figures.py Feb 9, 2023
@ofrei ofrei marked this pull request as ready for review February 9, 2023 22:04
@ofrei ofrei requested a review from espenhgn February 9, 2023 22:05
@ofrei
Copy link
Contributor Author

ofrei commented Feb 9, 2023

@espenhgn #126 worked very well, I squashed and merged in order to rebase my commits changing gwas.py (this PR).
If these changes are OK please merge. Best to use "rebase" - I'd like to keep those four commits separately, this way it'll be easier to spot any issue if this reformatting has introduced a regression. But test_gwas_py.py passes just fine )

Copy link
Contributor

@espenhgn espenhgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@espenhgn espenhgn merged commit 3666140 into main Feb 10, 2023
@espenhgn
Copy link
Contributor

@ofrei, please delete branch https://github.com/comorment/containers/tree/fix-127 if it's no longer needed.

@espenhgn espenhgn deleted the fix-127 branch June 25, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reformat gwas.py

2 participants