Skip to content

removed redundant LDpred2 example#141

Merged
espenhgn merged 4 commits intomainfrom
fix-140
Mar 6, 2023
Merged

removed redundant LDpred2 example#141
espenhgn merged 4 commits intomainfrom
fix-140

Conversation

@espenhgn
Copy link
Contributor

@espenhgn espenhgn commented Feb 27, 2023

Fixes #140

Changes proposed in this pull request:

  • Removed /usecases/LDpred2_tutorial
  • Moved tutorial data to /usecases/LDpred2_test/data/ in preparation for LDpred2 imputation #131

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.

@espenhgn espenhgn added the enhancement New feature or request label Feb 27, 2023
Copy link
Contributor

@deepchocolate deepchocolate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@deepchocolate
Copy link
Contributor

@espenhgn I just realized the public-data-* is used by LDpred2_test/run.sh, could you instead of removing these files move them to LDpred2_test/data?

@espenhgn
Copy link
Contributor Author

espenhgn commented Mar 2, 2023

@espenhgn I just realized the public-data-* is used by LDpred2_test/run.sh, could you instead of removing these files move them to LDpred2_test/data?

Sure can do!

Copy link
Contributor

@deepchocolate deepchocolate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@espenhgn
Copy link
Contributor Author

espenhgn commented Mar 3, 2023

@deepchocolate, I've moved the data and updated the run.sh script where it should function with #131.

@espenhgn espenhgn mentioned this pull request Mar 6, 2023
4 tasks
@espenhgn espenhgn merged commit 38fbe65 into main Mar 6, 2023
@espenhgn espenhgn deleted the fix-140 branch March 6, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LDpred2: remove /usecases/LDpred2_tutorial Rmarkdown example

2 participants