Skip to content

Fix #187#188

Merged
ofrei merged 5 commits intomainfrom
fix_187
Jun 23, 2023
Merged

Fix #187#188
ofrei merged 5 commits intomainfrom
fix_187

Conversation

@ofrei
Copy link
Contributor

@ofrei ofrei commented Jun 22, 2023

Fixes #187

Changes proposed in this pull request:

Revert a change introduced in 5e3ff1d

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

Copy link
Contributor

@espenhgn espenhgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you update the regenie version in the table (https://github.com/comorment/containers/tree/main/docker#software-versions)?

@ofrei ofrei merged commit a343a17 into main Jun 23, 2023
@ofrei ofrei mentioned this pull request Jun 23, 2023
4 tasks
@espenhgn espenhgn deleted the fix_187 branch June 25, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in gwas.py in handling of info, maf, hwe and geno filters

2 participants