Merged
Conversation
When using the default value of the gwas.py flag `vcf-field` the final flag output to SAIGE will be formatted as: ``` --vcfField=['DS'] ``` This commit fixes this, so that the final flag will instead be: ``` --vcfField=DS ```
Contributor
|
oh my, what a typo... @rzetterberg thanks for fixing this! |
Contributor
|
In the gwas_demo example I've been explicitly passing |
espenhgn
added a commit
that referenced
this pull request
Oct 5, 2022
# This is the 1st commit message: migrating files from GH/comorment/gwas@47a23f0 # This is the commit message #2: add shell script to convert from docker # This is the commit message #3: fix path # This is the commit message #4: move build artefact to singularity/<image>/. # This is the commit message #5: group/user ownership # This is the commit message #6: move built containers to dest. # This is the commit message #7: update download path for BOLT-LMM # This is the commit message #8: typos # This is the commit message #9: moved unused install scripts # This is the commit message #10: fixed failure to clone repos # This is the commit message #11: not including shapeit2 in gwas.sif # This is the commit message #12: not including impute4 in gwas.sif (license) # This is the commit message #13: run ./configure w. bcftools # This is the commit message #14: do not install mixer in python3.sif # This is the commit message #15: add saige # This is the commit message #16: removing enigma-cvn and matlabruntime sif files # This is the commit message #17: set channel priority # This is the commit message #18: don't include bgenix and htslib in python3.sif # This is the commit message #19: remove enigma-cnv dockerfile # This is the commit message #20: remove commented out stuff # This is the commit message #21: updated CHANGELOG # This is the commit message #22: renamed and move bash files used by make # This is the commit message #23: fixed typos # This is the commit message #24: add rudimentary build test scripts # This is the commit message #25: fix # This is the commit message #26: updated URL # This is the commit message #27: remove LAVA and lava_partitioning from r.sif # This is the commit message #28: blurb on src files # This is the commit message #29: remove unused installer scripts # This is the commit message #30: ignore .pyc files # This is the commit message #31: check for plink2 # This is the commit message #32: autopep8
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the default value of the gwas.py flag
vcf-fieldthe final flag output to SAIGE will be formatted as:This commit fixes this, so that the final flag instead will be output as: