Skip to content

GH actions (docker&python lint, greetings, stale)#72

Merged
espenhgn merged 7 commits intomainfrom
fix-44
Oct 25, 2022
Merged

GH actions (docker&python lint, greetings, stale)#72
espenhgn merged 7 commits intomainfrom
fix-44

Conversation

@espenhgn
Copy link
Contributor

@espenhgn espenhgn commented Oct 24, 2022

Fixes #44

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@espenhgn espenhgn marked this pull request as draft October 24, 2022 14:25
@espenhgn espenhgn marked this pull request as ready for review October 25, 2022 07:45
@espenhgn espenhgn requested a review from ofrei October 25, 2022 07:46
Copy link
Contributor

@ofrei ofrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
What about piping yes into the pip install commands? According to https://superuser.com/questions/816143/how-to-run-pip-in-non-interactive-mode that's the way to go for non-interactive pip installations.

Or is this only relevant if pip install pulls dependencies, and we'd rather like to list those dependencies manually, with benefit being that we'll have more control over versioning?

@espenhgn
Copy link
Contributor Author

espenhgn commented Oct 25, 2022

Looks good! What about piping yes into the pip install commands? According to https://superuser.com/questions/816143/how-to-run-pip-in-non-interactive-mode that's the way to go for non-interactive pip installations.

Or is this only relevant if pip install pulls dependencies, and we'd rather like to list those dependencies manually, with benefit being that we'll have more control over versioning?

I believe piping "yes" is redundant these days. The question on that page is eight years old :)
I changed it in this PR as the docker file linter that I added complained about it. Dependencies should be installed automatically.

@espenhgn espenhgn merged commit 716f009 into main Oct 25, 2022
@espenhgn espenhgn deleted the fix-44 branch October 25, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dockerfile recipes: Dockerfile linter action

2 participants