Conversation
ofrei
left a comment
There was a problem hiding this comment.
Looks good!
What about piping yes into the pip install commands? According to https://superuser.com/questions/816143/how-to-run-pip-in-non-interactive-mode that's the way to go for non-interactive pip installations.
Or is this only relevant if pip install pulls dependencies, and we'd rather like to list those dependencies manually, with benefit being that we'll have more control over versioning?
I believe piping "yes" is redundant these days. The question on that page is eight years old :) |
Fixes #44
Changes proposed in this pull request:
Before submitting
section of the
CONTRIBUTINGdocs.