Conversation
ofrei
reviewed
Nov 4, 2022
ofrei
approved these changes
Nov 4, 2022
Contributor
ofrei
left a comment
ofrei
left a comment
There was a problem hiding this comment.
Great! I agree with changes, and will follow the same pattern (remove temporary stuff from containers) from now on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68
Changes proposed in this pull request:
gwas.sifbuild from 861MB to 387MB; using/tools/only for BOLT-LMM binary and linked library./tmp/dir during Docker builds (gwas.sif,r.sif,python3.sif,hello.sif)Before submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.