Conversation
|
@ofrei, @deepchocolate, are you fine with this? |
ofrei
left a comment
There was a problem hiding this comment.
@espenhgn looks great, thanks for including bigsnpr in R.sif!
Could you also commit into our repository the ldpred2.R and run_ldpred2.sh scripts made by @deepchocolate ? The scripts from here: 33698fb
As for impute.R, I think we could switch to plink's https://www.cog-genomics.org/plink/1.9/data#fill_missing_a2 . This options works like this:
plink --bfile <bfile_in> --fill-missing-a2 --make-bed --out <bfile_out>
|
Hi @ofrei. I can include @deepchocolate's files of course. If you both agree, I can merge that branch into this one and move the .R and .sh files where I want them in order to keep the contributions tracked. |
|
@espenhgn I agree |
|
The only thing I didn't see that I know is needed for my R-script is the R-package argparser. Otherwise it looks great! |
Sorry, forgot to push this last minute change. |
LDPRED2 scripts for PRS analyses
|
@deepchocolate , I just have a question: This file If it's not can you push it to this branch? |
It should be the same yes! |
Fixes #90
Changes proposed in this pull request:
Note, I added the usecase files as
ldpred2_tmpas I think they will be superseded by those of branch deepchocolate/ldpred2 by @deepchocolate. When they are no longer needed, they can be removed I think.Should add that this edit only increases the size of the built container by about 100MB, from 1.4GB.
Before submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.