Skip to content

r.sif: add R bigsnpr and related tools for LDpred2 analysis#91

Merged
espenhgn merged 28 commits intomainfrom
fix-90
Nov 17, 2022
Merged

r.sif: add R bigsnpr and related tools for LDpred2 analysis#91
espenhgn merged 28 commits intomainfrom
fix-90

Conversation

@espenhgn
Copy link
Contributor

@espenhgn espenhgn commented Nov 11, 2022

Fixes #90

Changes proposed in this pull request:

Note, I added the usecase files as ldpred2_tmp as I think they will be superseded by those of branch deepchocolate/ldpred2 by @deepchocolate. When they are no longer needed, they can be removed I think.
Should add that this edit only increases the size of the built container by about 100MB, from 1.4GB.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@espenhgn espenhgn added the enhancement New feature or request label Nov 11, 2022
@espenhgn espenhgn marked this pull request as draft November 11, 2022 09:14
@espenhgn espenhgn marked this pull request as ready for review November 15, 2022 13:43
@espenhgn
Copy link
Contributor Author

@ofrei, @deepchocolate, are you fine with this?

Copy link
Contributor

@ofrei ofrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@espenhgn looks great, thanks for including bigsnpr in R.sif!
Could you also commit into our repository the ldpred2.R and run_ldpred2.sh scripts made by @deepchocolate ? The scripts from here: 33698fb
As for impute.R, I think we could switch to plink's https://www.cog-genomics.org/plink/1.9/data#fill_missing_a2 . This options works like this:

plink --bfile <bfile_in> --fill-missing-a2 --make-bed --out <bfile_out>

@espenhgn
Copy link
Contributor Author

espenhgn commented Nov 15, 2022

Hi @ofrei. I can include @deepchocolate's files of course. If you both agree, I can merge that branch into this one and move the .R and .sh files where I want them in order to keep the contributions tracked.

@ofrei
Copy link
Contributor

ofrei commented Nov 15, 2022

@espenhgn I agree

@deepchocolate
Copy link
Contributor

The only thing I didn't see that I know is needed for my R-script is the R-package argparser. Otherwise it looks great!

@espenhgn
Copy link
Contributor Author

The only thing I didn't see that I know is needed for my R-script is the R-package argparser. Otherwise it looks great!

Sorry, forgot to push this last minute change. argparser should be installed: https://github.com/comorment/containers/pull/91/files#diff-adcb955b173d581f71077f92f6a1872edb47f4f0dc61e0b23f3372a7d0dbe7fe

@espenhgn espenhgn marked this pull request as draft November 15, 2022 19:01
@espenhgn
Copy link
Contributor Author

@deepchocolate , I just have a question: This file Height.gwas.txt referenced on line

fileSumstats=Height.gwas.txt
, is that the same as this one (unzipped): https://github.com/comorment/containers/blob/deepchocolate/ldpred2/reference/examples/prsice2/Height.gwas.txt.gz?
If it's not can you push it to this branch?

@deepchocolate
Copy link
Contributor

@deepchocolate , I just have a question: This file Height.gwas.txt referenced on line

fileSumstats=Height.gwas.txt

, is that the same as this one (unzipped): https://github.com/comorment/containers/blob/deepchocolate/ldpred2/reference/examples/prsice2/Height.gwas.txt.gz?
If it's not can you push it to this branch?

It should be the same yes!

@espenhgn espenhgn marked this pull request as ready for review November 17, 2022 11:11
@espenhgn espenhgn merged commit c2f3348 into main Nov 17, 2022
@espenhgn espenhgn deleted the fix-90 branch November 17, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

r.sif: add bigsnpr and related tools for LDpred2 analysis

3 participants