Skip to content

some changelog/readme updates for v1.1#99

Merged
espenhgn merged 5 commits intomainfrom
fix-96-additions
Dec 1, 2022
Merged

some changelog/readme updates for v1.1#99
espenhgn merged 5 commits intomainfrom
fix-96-additions

Conversation

@espenhgn
Copy link
Contributor

Changelog/Readme updates for #96, which should've been included with PR #97

Changes proposed in this pull request:

  • Copy container-software table from src/README to CHANGELOG.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@espenhgn espenhgn requested a review from ofrei November 29, 2022 15:42
@ofrei
Copy link
Contributor

ofrei commented Nov 30, 2022

@espenhgn By the end of today I'm hoping to split out MAGMA, LAVA reference to a separate repo, and also move away some other .sif files that aren't a core part of the comorment containers. I'll will also rebase this branch once it's done.

@espenhgn
Copy link
Contributor Author

@espenhgn By the end of today I'm hoping to split out MAGMA, LAVA reference to a separate repo, and also move away some other .sif files that aren't a core part of the comorment containers. I'll will also rebase this branch once it's done.

Hi @ofrei. In which order shall we have this? If the v1.1 release does not include MAGMA, LAVA, etc., as you mention, that'd be fine by me. I'd merge this now anyway if you'd give the thumbs up :)

Copy link
Contributor

@ofrei ofrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@espenhgn I rebased and made a minor change1 and minor change2 in the CHANGELOG due to rebase. These are pushed to https://github.com/comorment/containers/tree/fix-96-additions-v2 branch. Please merge that branch or "git cherry-pick" those two commits.

@espenhgn espenhgn merged commit 202f30e into main Dec 1, 2022
@espenhgn espenhgn deleted the fix-96-additions branch December 1, 2022 09:52
@espenhgn
Copy link
Contributor Author

espenhgn commented Dec 1, 2022

@ofrei: Fyi, I've deleted the fix-96-additions-v2 branch on the remote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants