Fix Workspace.remove_object leaking Inbox-side registrations - #49
Merged
Conversation
remove_object() only forgot the Outbox's persisted material/visibility slots for a removed guid, never the Inbox's own geometry_registry, metadata_registry, object_actions_registry, buttons callback map, or (for a Brep) its brep_viewmesh_registry entry. Any workflow that repeatedly removes and re-adds objects under the same guid built up an unbounded set of stale entries for the life of the process. Adds Inbox.forget_geometry(), called from remove_object() alongside the existing Outbox cleanup.
gonzalocasas
approved these changes
Sep 4, 2026
gonzalocasas
left a comment
gonzalocasas
left a comment
Member
There was a problem hiding this comment.
lgtm! the PR's description is very hard to read, but that affects nothing anyway ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove_object() only forgot the Outbox's persisted material/visibility slots for a removed guid, never the Inbox's own geometry_registry, metadata_registry, object_actions_registry, buttons callback map, or (for a Brep) its brep_viewmesh_registry entry. Any workflow that repeatedly removes and re-adds objects under the same guid built up an unbounded set of stale entries for the life of the process.
Adds Inbox.forget_geometry(), called from remove_object() alongside the existing Outbox cleanup.