feat: add Codex Fast mode toggle - #255
Conversation
Expose the effective Codex Fast tier in the Harness status line. Add /fast to toggle Fast for the current session through native thread settings. Keep provider-specific behavior inside the Codex adapter and cover it with tests.
| type: "boolean", | ||
| name: "Fast", | ||
| category: "model", | ||
| value: isFastServiceTier(serviceTier) && model?.supportsFast !== false, |
There was a problem hiding this comment.
🤖 devloop code-review · seed-2.1-turbo
When codexModelSupportsFast returns undefined (old app-server that doesn't provide serviceTiers or additionalSpeedTiers in the model catalog), the Fast toggle appears as a normal, functional option with the description "Use Codex Fast mode for subsequent turns." The user has no indication that Fast support is unconfirmed.
If the user toggles Fast ON, setConfig's guard at line 1217 (selected?.supportsFast === false) passes because undefined !== false. The thread/settings/update RPC is sent with serviceTier: "priority". The server may reject this silently or with an error that the user cannot easily associate with model incompatibility.
The fix should treat undefined supportsFast as "unknown" rather than "supported": either disable the toggle with a descriptive message like "Fast mode support unknown for this app-server version", or omit the Fast option entirely when supportsFast is undefined.
ccr:fp=b00b989130bc
|
🤖 devloop code-review · 1 finding(s)（1 条已作为独立 review thread 发布） |
2 participants
Expose the effective Codex Fast tier in the Harness status line.
Add /fast to toggle Fast for the current session through native thread settings.
Keep provider-specific behavior inside the Codex adapter and cover it with tests.