refactor: extract plugin package loader - #274
Merged
Merged
Conversation
Move Package source selection, identity validation, caching, and concurrent load deduplication out of Manager into package-loader.ts. Keep Manager responsible for Instance and Binding lifecycle while preserving Package reload and Runner behavior.
Move Runner registration conversion for commands, context providers, and controllers out of Plugin Manager into runner/registration.ts. Keep Manager responsible only for activating the Runner and installing each reported registration through the Runner boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Package source selection, identity validation, caching, and concurrent
load deduplication out of Manager into package-loader.ts.
Keep Manager responsible for Instance and Binding lifecycle while preserving
Package reload and Runner behavior.
Move Runner registration conversion for commands, context providers, and
controllers out of Plugin Manager into runner/registration.ts.
Keep Manager responsible only for activating the Runner and installing each
reported registration through the Runner boundary.