feat(policy): add WorkingDir domain fact - #108
Merged
Merged
Conversation
Represent a command working directory as a value object whose missing path explicitly means the runtime did not provide enough location information. Keep the model additive for now so existing Command projection and rules remain unchanged while the execution-location migration proceeds in follow-up work.
Move the registered workspace-root comparison behind domain.workspace so command policies no longer need to rederive registry path semantics. Keep the API narrow: membership and repo lookup already have dedicated query surfaces, while the workspace guard only needs exact-root detection.
Project command locations as WorkingDir facts and make position-sensitive rules fail open when Codex omits a child Bash workdir. Parse the actual bare-key unified-exec payload so the top-level hook retains each nested command's workdir before duplicate Bash hooks are evaluated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Represent a command working directory as a value object whose missing path
explicitly means the runtime did not provide enough location information.
Keep the model additive for now so existing Command projection and rules remain
unchanged while the execution-location migration proceeds in follow-up work.
Move the registered workspace-root comparison behind domain.workspace so
command policies no longer need to rederive registry path semantics.
Keep the API narrow: membership and repo lookup already have dedicated query
surfaces, while the workspace guard only needs exact-root detection.
Project command locations as WorkingDir facts and make position-sensitive rules
fail open when Codex omits a child Bash workdir.
Parse the actual bare-key unified-exec payload so the top-level hook retains each
nested command's workdir before duplicate Bash hooks are evaluated.