fix: scope checkout ownership by harness - #122
Merged
Merged
Conversation
Store checkout owner locks as harness-prefixed files so sessions from the same harness contend while Claude and Codex remain independent. Introduce SessionIdentity to resolve hook payloads and runtime environment variables consistently across hooks and scripts.
qiankunli
commented
Jul 31, 2026
| owner = read(repo) | ||
| harness = rec["harness"] | ||
| f = _lock_file(repo, harness) | ||
| owner = read(repo, harness) |
Collaborator
Author
There was a problem hiding this comment.
🤖 devloop code-review · deepseek-v4-pro
The harness parameter is shadowed by harness = rec["harness"] on line 362. While functionally correct (the normalized value is consistently used throughout the function), shadowing the parameter name can confuse readers about which value is in effect. Consider using a different local variable name (e.g., normalized_harness) or normalizing the parameter before constructing rec.
ccr:fp=41f3858d2097
Collaborator
Author
|
🤖 devloop code-review · 1 finding(s)（1 条已作为独立 review thread 发布） |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store checkout owner locks as harness-prefixed files so sessions from the
same harness contend while Claude and Codex remain independent.
Introduce SessionIdentity to resolve hook payloads and runtime environment
variables consistently across hooks and scripts.