feat: publish code-taste and strengthen devloop workflows - #133
Conversation
qiankunli
commented
Aug 17, 2026
qiankunli
commented
- distribute code-taste as a standalone Claude and Codex plugin
- add a first-class start-work branch transaction reused by commit flow
- surface non-blocking guidance when make fix is unavailable
- distribute code-taste as a standalone Claude and Codex plugin - add a first-class start-work branch transaction reused by commit flow - surface non-blocking guidance when make fix is unavailable
| guidance=(*guidance, *result.guidance), | ||
| ) | ||
| except Exception as e: # gate fail-closed | ||
| return HookResult(name=name, ok=False, summary=f"{name} errored: {e}") |
There was a problem hiding this comment.
🤖 devloop code-review · seed-2.1-turbo · ready in 2m 40s
When a preparation step (e.g. normalize for lint) succeeds and returns guidance, but the corresponding handler (lint) subsequently throws an exception, the preparation guidance is silently discarded. The except branch on line 190 constructs a bare HookResult(name=name, ok=False, summary=...) without including preparation_guidance[name].
By contrast, when preparation itself fails (lines 156-161), the guidance is carried through in the HookResult. This inconsistency means that the most useful scenario for guidance — "here's how to fix your setup" when a gate crashes — loses the advice the user needs to resolve the failure.
ccr:fp=ae01322f70e4
|
🤖 devloop code-review · 1 finding(s)（1 条已作为独立 review thread 发布） |
2 participants
