Feature Worthington jets video on homepage#103
Open
VatsalSy wants to merge 1 commit into
Open
Conversation
Embed the full video with the paper entry and show a muted 20-second hero loop. Preserve reduced-motion behaviour and clear anchored paper links below the fixed header.
There was a problem hiding this comment.
Pull request overview
This PR updates the site’s homepage hero and research page to feature the new “Self-similar Worthington jets” preprint, including a short hero treatment and a full privacy-enhanced video embed, while improving slide timing/anchor behavior.
Changes:
- Adds a new Worthington jets YouTube hero slide with configurable per-slide dwell time and optional
end=timestamp. - Updates the homepage hero rotator logic to support per-slide durations and to reset media when slides reactivate, with reduced-motion handling for autoplay/loop parameters.
- Adds a stable anchor + full video embed to the research entry and adjusts scroll offsets for direct anchor navigation under a fixed header.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
index.html |
Adds per-slide data-duration, supports optional YouTube end times, and updates the hero carousel runtime logic (including reduced-motion behavior). |
assets/css/research-v2.css |
Adds scroll offset handling (scroll-margin-top) for research paper containers/headings to avoid fixed-header overlap on anchor navigation. |
_research/index.md |
Adds a stable anchor for the Worthington jets entry and embeds the full YouTube (nocookie) video with privacy-related attributes. |
_data/hero.yml |
Adds the Worthington jets hero slide data and documents new per-slide duration and youtube_end fields. |
Comments suppressed due to low confidence (1)
index.html:336
- Inactive hero slides are only hidden via
opacity: 0(see assets/css/home.css), so their<video>and especially the new YouTube<iframe>will continue playing in the background. This can waste bandwidth/CPU (particularly on mobile) even when the slide isn’t visible. Consider pausing the outgoing<video>and blanking the outgoing<iframe>src when a slide deactivates, then restoring from a storeddata-srcwhen the slide becomes active again.
function advance() {
figures[idx].setAttribute('data-active', 'false');
figures[idx].setAttribute('aria-hidden', 'true');
figures[idx].setAttribute('inert', '');
idx = (idx + 1) % figures.length;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
_data/hero.ymlTesting
npm test -- --runInBand(83 tests passed)npm run lint:css(passed)./scripts/lint-check.sh(passed)bash scripts/validate-content-rules.sh(passed)python3 scripts/check-content-rules-trigger-parity.py(passed)./scripts/build.sh(passed)git diff --check(passed)