[cpyrt] Reuse InitializerListConverter element converters - #54
Merged
aaronj0 merged 1 commit intoAug 31, 2026
Merged
Conversation
guitargeek
requested changes
Aug 31, 2026
guitargeek
left a comment
guitargeek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! I think we can unify this to a single "CreateConverter" path though
SetArg() created an element converter per call and appended it to fConverters, but Clear() frees only fBuffer, so the vector grew without bound across repeated std::initializer_list conversions. Create each element converter once, on first use of its index, and reuse it.
aaronj0
force-pushed
the
reuse-initlist-converters
branch
from
August 31, 2026 17:58
e43a07c to
6951eb0
Compare
vgvassilev
pushed a commit
to vgvassilev/cppjit
that referenced
this pull request
Sep 6, 2026
…esearch#54) SetArg() created an element converter per call and appended it to fConverters, but Clear() frees only fBuffer, so the vector grew without bound across repeated std::initializer_list conversions. Create each element converter once, on first use of its index, and reuse it.
aaronj0
added a commit
to aaronj0/cppjit-compres
that referenced
this pull request
Sep 6, 2026
…esearch#54) SetArg() created an element converter per call and appended it to fConverters, but Clear() frees only fBuffer, so the vector grew without bound across repeated std::initializer_list conversions. Create each element converter once, on first use of its index, and reuse it.
aaronj0
added a commit
to aaronj0/cppjit-compres
that referenced
this pull request
Sep 6, 2026
…esearch#54) SetArg() created an element converter per call and appended it to fConverters, but Clear() frees only fBuffer, so the vector grew without bound across repeated std::initializer_list conversions. Create each element converter once, on first use of its index, and reuse it.
aaronj0
added a commit
to aaronj0/cppjit-compres
that referenced
this pull request
Sep 6, 2026
…esearch#54) SetArg() created an element converter per call and appended it to fConverters, but Clear() frees only fBuffer, so the vector grew without bound across repeated std::initializer_list conversions. Create each element converter once, on first use of its index, and reuse it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetArg() created an element converter per call and appended it to fConverters, but Clear() frees only fBuffer, so the vector grew without bound across repeated std::initializer_list conversions. Create each element converter once and reuse it.
Upstreamed from the ROOT migration